Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(secretmanager): Added samples for delete secret annotation in Secret Manager#13511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
durgesh-ninave-crest wants to merge4 commits intoGoogleCloudPlatform:main
base:main
Choose a base branch
Loading
fromdurgesh-ninave-crest:secretmanager-label-and-annotation-samples

Conversation

durgesh-ninave-crest
Copy link
Contributor

@durgesh-ninave-crestdurgesh-ninave-crest commentedJul 18, 2025
edited
Loading

Description

Created samples for Global and Regional Secret Manager API

Samples

  • Delete Secret Annotation
  • Delete Regional Secret Annotations

Also, fixed the TypeError in some samples by changing the initialization oflabels andannotations from a set to a dictionary.

Checklist

@product-auto-labelproduct-auto-labelbot added api: secretmanagerIssues related to the Secret Manager API. samplesIssues that are directly related to samples. labelsJul 18, 2025
Copy link
Contributor

@gemini-code-assistgemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Summary of Changes

Hello@durgesh-ninave-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the sample coverage for Google Cloud Secret Manager by introducing new Python examples that demonstrate advanced management of secret metadata, specifically focusing on labels and annotations. It also addresses a critical bug by correcting the data structure used for labels and annotations in several existing samples, improving their reliability and correctness.

Highlights

  • New Secret Manager Samples: I've added new Python samples for Google Cloud Secret Manager, specifically demonstrating how to edit secret labels and delete secret annotations. These samples cover both global and regional Secret Manager API interactions.
  • Bug Fix: TypeError in Samples: I've addressed aTypeError in several existing Secret Manager samples. The issue stemmed fromlabels andannotations being incorrectly initialized as sets ({key, value}) instead of dictionaries ({key: value}). This has been corrected across all affected samples.
  • Expanded Test Coverage: Corresponding unit tests have been added or updated insnippets_test.py andregional_samples/snippets_test.py to validate the functionality of the newly introduced samples for deleting annotations and editing labels.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands.

FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in issue comments and review comments.
Help/gemini helpDisplays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

  1. Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.

Copy link
Contributor

@gemini-code-assistgemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

The pull request introduces new samples for managing secret labels and annotations in both global and regional Secret Manager APIs, and fixes a bug in existing samples related toTypeError on label and annotation initialization.

@durgesh-ninave-crestdurgesh-ninave-crest changed the titlefeat(secretmanager): Add samples for labels and annotations in Secret Managerfeat(secretmanager): Added samples for delete secret annotation in Secret ManagerJul 18, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: secretmanagerIssues related to the Secret Manager API.samplesIssues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@durgesh-ninave-crest

[8]ページ先頭

©2009-2025 Movatter.jp