- Notifications
You must be signed in to change notification settings - Fork6.6k
Add script to efficiently delete a large number of nested empty folders in an HNS bucket.#13497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View thisfailed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Summary of Changes
Hello@mabsaleh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new script to efficiently delete a large number of nested empty folders in a Google Cloud Storage (GCS) Hierarchical Namespace (HNS) enabled bucket. The script uses a recursive, depth-first approach with parallel execution to improve performance. The pull request also includes an updated README with instructions on how to use the script.
Highlights
- New script: Added a new Python script,
delete-empty-folders.py, to efficiently delete a large number of nested empty folders in a GCS HNS bucket. - README update: Updated the
README.mdfile to include documentation and usage instructions for the new script. - Recursive Deletion: The script traverses and deletes nested empty folders using a depth-first approach.
- Parallel Execution: The script uses a thread pool to delete folders concurrently for improved performance.
- Configurable: The script allows setting the target bucket, folder prefix, and number of workers.
- Error Handling: The script includes retry logic for transient errors and logs failures.
- Progress Reporting: The script periodically logs deletion statistics.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review | Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary | Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help | Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.
Footnotes
Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
The pull request introduces a script for efficiently deleting empty folders in GCS HNS buckets. I've provided feedback to correct a typo in the README and to improve the script's configuration validation and error handling.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
chandra-siri commentedJul 18, 2025
@mabsaleh could you please fix the kokoro failures |
Add script to efficiently delete a large number of nested empty folders in an HNS bucket.
Seehttps://cloud.google.com/storage/docs/hns-buckets-best-practices#folder-management for additional context.
Checklist
nox -s py-3.9(seeTest Environment Setup)nox -s lint(seeTest Environment Setup)