- Notifications
You must be signed in to change notification settings - Fork6.6k
feat(genai): Demonstrate how to get token count#13428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Summary of Changes
Hello@kaycebasques, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've made a small update to thecounttoken_compute_with_txt.py sample. The change adds a line to print the actual token count derived from the response, making the output clearer for users running the sample. I also updated the example output comment to match.
Highlights
- Display Token Count: Added a print statement to explicitly show the computed token count by getting the length of the tokens list from the response object.
- Update Example Output: Modified the inline comment showing the example output to include the line printing the token count, reflecting the change.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review | Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary | Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help | Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.
Footnotes
Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configureGemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
This pull request demonstrates how to retrieve and print a token count from thecompute_tokens method's response. The suggestion focuses on making the token calculation more robust by summing tokens from all parts inresponse.tokens_info, which handles potential edge cases more gracefully.
| @@ -25,12 +25,14 @@ def compute_tokens_example() -> int: | |||
| ) | |||
| print(response) | |||
| print(f"token count: {len(response.tokens_info[0].tokens)}") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
To handle cases whereresponse.tokens_info might be empty or contain multiple elements, consider summing the token counts from allTokensInfo objects withinresponse.tokens_info for a more robust approach.
print(f"token count:{sum(len(info.tokens)forinfoinresponse.tokens_info)}")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree that the suggestion is more approach but this is a pretty simple example. I don't think we need to complicate it with the fully robust solution. The goal here is to understand basic usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@kaycebasques could you update the approach so that it does handle an empty response? The basic usage is the goal, and if it fails for whatever reason having the sample address it encourages the recommended practice.
Checklist
nox -s py-3.9(seeTest Environment Setup)nox -s lint(seeTest Environment Setup)