Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add storage batch operations samples#4180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
thiyaguk09 wants to merge10 commits intoGoogleCloudPlatform:main
base:main
Choose a base branch
Loading
fromthiyaguk09:storagebatchoperations-samples

Conversation

@thiyaguk09
Copy link

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines fromCONTRIBUTING.MD andSamples Style Guide
  • Tests pass:npm test (seeTesting)
  • Lint pass:npm run lint (seeStyle)
  • Required CI tests pass (seeCI testing)
  • These samples need a newAPI enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updatedenv vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off ofGoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated theCODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I createdGitHub Actions workflow for this sample
  • This sample adds a newProduct API, and I updated theBlunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Pleasemerge this PR for me once it is approved

Note: Any check with(dev),(experimental), or(legacy) can be ignored and shouldnot block your PR from merging (seeCI testing).

@product-auto-labelproduct-auto-labelbot added the samplesIssues that are directly related to samples. labelSep 11, 2025
@thiyaguk09thiyaguk09force-pushed thestoragebatchoperations-samples branch frome7476df toc1d08bdCompareSeptember 12, 2025 07:52
@thiyaguk09thiyaguk09 marked this pull request as ready for reviewSeptember 12, 2025 09:52
@thiyaguk09thiyaguk09 requested review froma team ascode ownersSeptember 12, 2025 09:52
@snippet-bot
Copy link

snippet-botbot commentedSep 12, 2025•
edited
Loading

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated bysnippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, addsnippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@thiyaguk09thiyaguk09force-pushed thestoragebatchoperations-samples branch fromc1d08bd tob424e2cCompareSeptember 22, 2025 08:15
@thiyaguk09
Copy link
Author

@ddelgrosso1 Just a friendly reminder to review this PR when you get a chance. Thanks!

@thiyaguk09
Copy link
Author

@ddelgrosso1 Could you please merge this PR if possible?

@thiyaguk09thiyaguk09force-pushed thestoragebatchoperations-samples branch fromfb51efe to6f5d870CompareOctober 17, 2025 13:38
Copy link

@chandra-sirichandra-siri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Added a minor comment. Nothing blocking.

…on & Error Handling)Improve the robustness and clarity of the Storage Batch Operations APIsamples:* **Error Handling:** Wraps all asynchronous Batch Operations APIsamples (Create, Get, List, Cancel) in `try...catch` blocks forproduction readiness.* **Specific Diagnostics:** Adds specific gRPC error code checks(`NOT_FOUND`, `FAILED_PRECONDITION`) within the `catch` blocks toprovide detailed diagnostic feedback to users regarding job state ornon-existence.* **Documentation:** Clarifies JSDoc for all function parameters (e.g.,`projectId`, `jobId`, `objectPrefix`), ensuring examples and types areclear for developers.
@thiyaguk09thiyaguk09force-pushed thestoragebatchoperations-samples branch from6f5d870 to7dceeccCompareOctober 24, 2025 06:51
@ddelgrosso1
Copy link
Contributor

Looks like Storage Intelligence is not enabled for the long-door-651 project. You will need to reach out to a member of the Cloud SDK Node team to get it enabled.

thiyaguk09 reacted with thumbs up emojithiyaguk09 reacted with eyes emoji

@thiyaguk09
Copy link
Author

@ddelgrosso1 Storage Intelligence permission has been enabled, and I am currently unable to run tests from my end. Could you please review it once?

@thiyaguk09
Copy link
Author

@ddelgrosso1,@chandra-siri Could you please run the test cases again? I don't have permission to do so on my end. I have received confirmation that Storage Intelligence permission has been granted.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chandra-sirichandra-sirichandra-siri approved these changes

@ddelgrosso1ddelgrosso1Awaiting requested review from ddelgrosso1

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

samplesIssues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thiyaguk09@ddelgrosso1@chandra-siri
[8]ページ先頭
©2009-2025 Movatter.jp