Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: compute_snapshot_schedule_attach/list#3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
gryczj wants to merge11 commits intomain
base:main
Choose a base branch
Loading
fromcompute_snapshot_schedule_attach

Conversation

@gryczj
Copy link
Contributor

@gryczjgryczj commentedDec 2, 2024
edited
Loading

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines fromCONTRIBUTING.MD andSamples Style Guide
  • Tests pass:npm test (seeTesting)
  • Lint pass:npm run lint (seeStyle)
  • These samples need a newAPI enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updatedenv vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off ofGoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated theCODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I createdGitHub Actions workflow for this sample
  • This sample adds a newProduct API, and I updated theBlunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Pleasemerge this PR for me once it is approved

@gryczjgryczj added kokoro:force-runAdd this label to force Kokoro to re-run the tests. kokoro:runAdd this label to force Kokoro to re-run the tests. labelsDec 2, 2024
@gryczjgryczj requested review froma team ascode ownersDecember 2, 2024 15:09
@snippet-bot
Copy link

snippet-botbot commentedDec 2, 2024
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated bysnippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, addsnippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-labelproduct-auto-labelbot added the samplesIssues that are directly related to samples. labelDec 2, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@gryczj and reviewers,

I'm currently reviewing this pull request and will post my detailed review in a few minutes. In the meantime, here's a quick summary to help everyone get up to speed:

This pull request adds functionality for managing Compute Engine snapshot schedules. Specifically, it introduces three new JavaScript samples:

  • createSnapshotSchedule.js: Creates a new snapshot schedule with customizable settings (daily, weekly, or monthly; retention policy; labels).
  • attachSnapshotSchedule.js: Attaches an existing snapshot schedule to a Compute Engine disk.
  • deleteSnapshotSchedule.js: Deletes a snapshot schedule. Note that this will fail if the schedule is attached to a disk.

Each sample includes comprehensive comments and error handling. Unit tests are also provided inattachSnapshotSchedule.test.js to verify the functionality.

The intent is to provide developers with clear, concise examples for working with Compute Engine snapshot schedules using the Node.js client library. This enhances the documentation and makes it easier for users to automate disk snapshots.


And now, a little haiku to lighten the mood:

Code flows like a stream,
Tests run, bugs swim downstream,
Clean code shines so bright.

Looking forward to the discussion!

@product-auto-labelproduct-auto-labelbot added the api: computeIssues related to the Compute Engine API. labelDec 2, 2024
@gryczjgryczj requested a review fromiennaeDecember 2, 2024 15:10
@gryczjgryczjforce-pushed thecompute_snapshot_schedule_attach branch from149ac9e to307b652CompareDecember 2, 2024 15:10
@@ -0,0 +1,103 @@
/*
* Copyright 2024 Google LLC
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

sample was added for testing purposes

* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

sample was added for testing purposes

@gryczjgryczjforce-pushed thecompute_snapshot_schedule_attach branch from84d3b32 to422a024CompareDecember 3, 2024 08:21
@gryczjgryczjforce-pushed thecompute_snapshot_schedule_attach branch from422a024 to0397137CompareDecember 4, 2024 13:35
@gryczjgryczj changed the titlefeat: compute_snapshot_schedule_attachfeat: compute_snapshot_schedule_attach/listDec 4, 2024
@BigBlackWolfBigBlackWolf self-requested a reviewDecember 5, 2024 11:55
@kweinmeister
Copy link
Collaborator

Can you please try to fix the conflict@gryczj ?

@rsamborski
Copy link
Member

@BigBlackWolf PTAL

@BigBlackWolf
Copy link

Oh, I noticed that wrote a comment, but didn't submit 😅 Thanks,@rsamborski

Can you please try to fix the conflict@gryczj ?

Joanna is on vacations and I am going to support her with open PRs.@kweinmeister I've resolved the conflicts, do you have any other concerns?

@ghost
Copy link

Gemini encountered an error creating the walkthrough. You can try again by commenting@code-review-assist walkthrough.

@iennae
Copy link
Contributor

@code-review-assist walkthrough

1 similar comment
@umairidris
Copy link
Member

@code-review-assist walkthrough

@ghost
Copy link

Gemini encountered an error creating the walkthrough. You can try again by commenting@code-review-assist walkthrough.

@umairidris
Copy link
Member

@code-review-assist walkthrough

@ghost
Copy link

Gemini encountered an error creating the walkthrough. You can try again by commenting@code-review-assist walkthrough.

@umairidris
Copy link
Member

@code-review-assist walkthrough

@ghost
Copy link

Gemini encountered an error creating the walkthrough. You can try again by commenting@code-review-assist walkthrough.

@m-strzelczyk
Copy link
Contributor

The users that are currently failing CLA had CLA signed at the time they were committing the changes. Please force-merge the PR.

@glasntglasnt added the waiting-for-responseWaiting for the author's response. labelAug 25, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@m-strzelczykm-strzelczykm-strzelczyk approved these changes

@iennaeiennaeAwaiting requested review from iennae

@BigBlackWolfBigBlackWolfAwaiting requested review from BigBlackWolf

+1 more reviewer

@code-review-assist-experimentalcode-review-assist-experimental[bot]code-review-assist-experimental[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@BigBlackWolfBigBlackWolf

Labels

api: computeIssues related to the Compute Engine API.kokoro:force-runAdd this label to force Kokoro to re-run the tests.kokoro:runAdd this label to force Kokoro to re-run the tests.samplesIssues that are directly related to samples.waiting-for-responseWaiting for the author's response.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gryczj@kweinmeister@rsamborski@BigBlackWolf@iennae@umairidris@m-strzelczyk@glasnt

[8]ページ先頭

©2009-2025 Movatter.jp