I have followedSample Format Guide
pom.xml parent set to latestshared-configuration
Appropriate changes to README are included in PR
These samples need a newAPI enabled in testing projects to pass (let us know which ones)
These samples need a new/updatedenv vars in testing projects set to pass (let us know which ones)
Tests pass:mvn clean verifyrequired
Lint passes:mvn -P lint checkstyle:checkrequired
Static Analysis:mvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only
This sample adds a new sample directory, and I updated theCODEOWNERS file with the codeowners for this sample
This sample adds a newProduct API, and I updated theBlunderbuss issue/PR auto-assigner with the codeowners for this sample
[x ] Pleasemerge this PR for me once it is approved

Added test cases for InfiniteStreamRecognize class

32c1664

abhasal requested review fromyoshi-approver anda team ascode owners

August 26, 2024 16:01

Copy link

google-clabot commentedAug 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View thisfailed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

product-auto-labelbot added samples

Issues that are directly related to samples.

api: speechIssues related to the Speech-to-Text API. labels

Aug 26, 2024

blunderbuss-gcfbot assignedbourgeoisor

Aug 26, 2024

Sita04 assignedminherz and unassignedbourgeoisor

Aug 27, 2024

minherz added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. label

Sep 3, 2024

kokoro-team removed kokoro:force-runAdd this label to force Kokoro to re-run the tests. labels

Sep 3, 2024

minherz requested changes

Sep 3, 2024

View reviewed changes

Copy link

Contributor

minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

what is an expected running time for this test?
based on lack of test input it looks like the code sample will wait for input and get terminated after 5 minutes.

speech/src/test/java/com/example/speech/InfiniteStreamRecognizeIT.java

Comment on lines +45 to +51

		System.setErr(new PrintStream(stderr));
		}

		@After
		public void tearDown() {
		System.setOut(originalStdout);
		System.setErr(originalStderr);

Copy link

Contributor

minherzSep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit: what is a reason to intercept Stderr if the test validates only Stdout?

minherz marked this pull request as draft

September 3, 2024 18:44

Copy link

Contributor

minherz commentedSep 3, 2024

I converted PR to draft because it does not pass automatic testing. Please, ensure that all tests pass before submitting it to the review.
It seems that the execution time of the test is bound by 5 min waiting for microphone input that is hard-coded in the code sample. If my interpretation is correct, the code sample and test should be modified to bring the running time of the test under 1 min.