Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: adding support for Java25 tests to work properly in CI#10199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
maigovannon wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromfeature/kokoro-java25

Conversation

@maigovannon
Copy link
Contributor

@maigovannonmaigovannon commentedNov 3, 2025•
edited
Loading

Description

This is one of the changes from#10193

Checklist

@product-auto-labelproduct-auto-labelbot added the samplesIssues that are directly related to samples. labelNov 3, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello@maigovannon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for Java 25 within the continuous integration environment. By updating the CI script to acknowledge Java 25 as a valid target version, it ensures that projects configured to compile against Java 25 can be tested and validated without encountering version-related failures in the CI pipeline. This is a foundational step towards broader compatibility with newer Java releases.

Highlights

  • CI Configuration: The.kokoro/tests/run_test_java.sh script has been updated to include Java 25 in the list ofALLOWED_VERSIONS. This change enables the CI system to properly recognize and validate projects targeting Java 25.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

  1. Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩

Copy link
Contributor

@gemini-code-assistgemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request adds support for Java 25 to the CI process by updating the.kokoro/tests/run_test_java.sh script. The change correctly adds "25" to the list of allowed Java versions. The implementation is straightforward and I have no further feedback.

Copy link
Contributor

@iennaeiennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There is not supporting java25 infrastructure as far as I can tell in gcr.io/cloud-devrel-kokoro-resources/ yet.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@iennaeiennaeiennae requested changes

@yoshi-approveryoshi-approverAwaiting requested review from yoshi-approveryoshi-approver is a code owner

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

samplesIssues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maigovannon@iennae
[8]ページ先頭
©2009-2025 Movatter.jp