GoogleCloudPlatform/java-docs-samplesPublic

NotificationsYou must be signed in to change notification settings
Fork2.9k
Star1.9k

feat: update functions samples#10197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

maigovannon wants to merge2 commits intomain

base:main

Choose a base branch

fromfeature/functions

Open

feat: update functions samples#10197

maigovannon wants to merge2 commits intomainfromfeature/functions

Conversation

Copy link

Contributor

maigovannon commentedNov 3, 2025•
edited
Loading

Description

Creating Java25 doc samples for Cloud Run Functions and updating some of the existing ones to Java21. These are forked changes from#10193

Checklist

I have followedSample Format Guide
pom.xml parent set to latestshared-configuration
Appropriate changes to README are included in PR
Tests pass:mvn clean verifyrequired
Lint passes:mvn -P lint checkstyle:checkrequired
Static Analysis:mvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only

feat: update functions samples

fb9cc8a

maigovannon requested review froma team andyoshi-approver ascode owners

November 3, 2025 11:38

product-auto-labelbot added samples

Issues that are directly related to samples.

api: cloudfunctionsIssues related to the Cloud Run functions API. labels

Nov 3, 2025

Copy link

Contributor

gemini-code-assistbot commentedNov 3, 2025

Summary of Changes

Hello@maigovannon, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Java compiler version for several function samples from Java 11 to Java 21. The primary purpose is to modernize the build configurations for these samples, ensuring they leverage the latest LTS features and maintain compatibility with contemporary Java development environments. This update affects thehelloworld andpubsub samples, bringing theirpom.xml configurations up to date.

Highlights

Java Version Update: Themaven.compiler.target andmaven.compiler.source properties have been updated from Java 11 to Java 21 in thepom.xml files for thehelloworld andpubsub function samples.
Sample Modernization: This change ensures that the specified function samples are compiled and run using the latest Long-Term Support (LTS) version of Java, aligning them with current development standards.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩

gemini-code-assistbot reviewed

Nov 3, 2025

View reviewed changes

Copy link

Contributor

gemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request updates the Java compiler source and target versions from 11 to 21 for two function samples. The changes in thepom.xml files are correct. I've added a couple of suggestions to improve maintainability by using a property for the Java version, which is a common best practice in Maven projects. This will make future version updates simpler and less prone to error.

functions/helloworld/helloworld/pom.xmlShow resolvedHide resolved

functions/v2/pubsub/pom.xmlShow resolvedHide resolved

maigovannon requested review fromiennae andludoch

November 3, 2025 12:35

maigovannon mentioned this pull request

Nov 3, 2025

Adding new Doc Samples for Java25#10193

Closed

6 tasks

Fixing PubSub for Java21 compatibility

b0b9764

iennae reviewed

Nov 4, 2025

View reviewed changes

functions/v2/pubsub/pom.xml

		<functionTarget>functions.SubscribeToTopic</functionTarget>
		</configuration>
		</plugin>
		<plugin>

Copy link

Contributor

iennaeNov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I get why you would add this but I'm not sure we should be adding this to the sample code. We want to illustrate using the Google Cloud Run function with Pub/Sub with a minimal example. This feels like it's adding complexity.

Copy link

ContributorAuthor

maigovannonNov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This was actually needed to makemvn clean verify work properly. Without this, it fails.

iennae reviewed

Nov 4, 2025

View reviewed changes

functions/helloworld/helloworld/pom.xml

		<properties>
		<maven.compiler.target>11</maven.compiler.target>
		<maven.compiler.source>11</maven.compiler.source>
		<maven.compiler.target>21</maven.compiler.target>

Copy link

Contributor

iennaeNov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We generally do not have samples for every run time in Functions. Java 11 is the minimum required runtimehttps://docs.cloud.google.com/run/docs/runtimes/java and that's why this is 11 currently. If y'all are thinking to move to latest supported (non-preview) that's fine, but it would be helpful to know that's the intent here. We should not have duplicate samples showing the basic usecase.