I have followedSample Format Guide
pom.xml parent set to latestshared-configuration
Appropriate changes to README are included in PR
These samples need a newAPI enabled in testing projects to pass (let us know which ones)
These samples need a new/updatedenv vars in testing projects set to pass (let us know which ones)
Tests pass:mvn clean verifyrequired
Lint passes:mvn -P lint checkstyle:checkrequired
Static Analysis:mvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only
This sample adds a new sample directory, and I updated theCODEOWNERS file with the codeowners for this sample
This sample adds a newProduct API, and I updated theBlunderbuss issue/PR auto-assigner with the codeowners for this sample
Pleasemerge this PR for me once it is approved

chore:upgrade java8 to java21 for appidentity folder

6937350

Alesvoy requested review froma team andyoshi-approver ascode owners

August 22, 2025 22:34

Copy link

snippet-botbot commentedAug 22, 2025

Here is the summary of changes.

You are about to add 3 region tags.

appengine-java21/appidentity/src/main/java/com/example/appengine/appidentity/SignForAppServlet.java:57, taggae_java8_app_identity_other_services
appengine-java21/appidentity/src/main/java/com/example/appengine/appidentity/UrlShortener.java:34, taggae_java21_app_identity_google_apis
appengine-java21/appidentity/src/main/java/com/example/appengine/appidentity/UrlShortener.java:77, taggae_java21_app_identity_google_apis

This comment is generated bysnippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, addsnippet-bot:force-run label or use the checkbox below:

Refresh this comment

Copy link

google-clabot commentedAug 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View thisfailed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

product-auto-labelbot added the samplesIssues that are directly related to samples. label

Aug 22, 2025

gemini-code-assistbot reviewed

Aug 22, 2025

View reviewed changes

Copy link

Contributor

gemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Summary of Changes

Hello@Alesvoy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a new App Engine sample for the App Identity API, designed to run on the Java 21 runtime. The sample showcases various aspects of the App Identity service, such as retrieving application identity information, digitally signing data, and using the application's identity to authenticate with other Google Cloud services. It provides a practical example for developers looking to integrate App Identity features into their Java 21 App Engine applications.

Highlights

New Java 21 App Engine Sample: This pull request introduces a brand new sample for the App Identity API, specifically configured to run on the Java 21 runtime environment within Google App Engine.
Comprehensive App Identity Demonstrations: The sample demonstrates key functionalities of the App Identity API, including retrieving the default version hostname, signing arbitrary data and verifying its signature, and obtaining access tokens to authenticate with other Google APIs (e.g., URL Shortener).
Compiler Version Note: While theappengine-web.xml explicitly sets the runtime tojava21, thepom.xml still specifiesmaven.compiler.target andmaven.compiler.source as1.8. This means the code is compiled for Java 8 compatibility, even when running on a Java 21 environment. This might be an area for future enhancement to leverage Java 21 language features.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩

gemini-code-assistbot reviewed

Aug 22, 2025

View reviewed changes

Copy link

Contributor

gemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request aims to upgrade the App Identity sample to Java 21. While this is a good initiative, there are several critical issues that need to be addressed. Thepom.xml still targets Java 1.8 and uses the outdatedjavax.servlet API instead ofjakarta.servlet required for modern runtimes. Furthermore, the URL shortener example uses a Google API that was deprecated and shut down in 2019, making that part of the sample non-functional. There are also other high and medium severity issues detailed in the comments, such as security vulnerabilities and outdated practices. Please address these points to ensure the sample is correct, secure, and up-to-date for Java 21.