- Notifications
You must be signed in to change notification settings - Fork2.9k
chore(modelarmor): Added floor settings tests#10106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
chore(modelarmor): Added floor settings tests#10106
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Summary of Changes
Hello@mihirvala-crestdata, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces new integration tests for the Model Armor Floor Settings API across different resource levels (Project, Folder, Organization). The tests are currently disabled using@Ignore because of a known issue with the API they interact with. The code includes placeholders for environment variable checks and cleanup that will be enabled once the API is functional.
Highlights
- New Floor Settings Tests: I've added new integration tests for the Model Armor Floor Settings API, covering
GetandUpdateoperations. - Resource Hierarchy Coverage: The new tests are designed to verify Floor Settings at the Project, Folder, and Organization levels.
- Tests Marked as Ignored: All newly added Floor Setting tests are currently marked with
@Ignoredue to an ongoing issue with the underlying API (referenced by buganizer ticket b/424365799). - Setup/Teardown Logic Added: I've included commented-out code in
beforeAllandafterAllto handle environment variable requirements and potentially reset floor settings, which should be uncommented once the API issue is resolved.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review | Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary | Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help | Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.
Footnotes
Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configureGemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
This pull request introduces new integration tests for floor settings in Model Armor. The tests cover getting and updating floor settings for projects, folders, and organizations.
Key changes include:
- Addition of new test methods, currently marked with
@Ignoredue to an ongoing API issue (b/424365799). - Configuration for
FOLDER_IDandORGANIZATION_IDvia environment variables. - Implementation of a
resetFloorSettingsmethod in@AfterClassto clean up test resources, which is good practice, though currently commented out along with the tests.
The changes are well-structured and the intent to add comprehensive tests is clear. The use ofTODO comments to track the pending API fix is appropriate. A few minor stylistic suggestions regarding blank lines have been made.
31549ab toa438abfCompare| // Tests for Folder setting snippets. | ||
| @Test | ||
| public void testGetOrganizationFloorSetting() throws IOException { | ||
| GetOrganizationFloorSetting.getOrganizationFloorSetting(ORGANIZATION_ID); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we have assertions for the actual value that was fetched by thegetOrganizationFloorSetting method? Similarly for other tests.
mihirvala-crestdataJul 8, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We followed a similar pattern to other snippet tests (seeSecret Manager tests). The goal of these tests is to verify that the snippets run successfully by asserting the presence of a success log.
NOTE: Please set following environment variables required for running tests: |
IAM settings should have been changed for this project, but the tests are still failing. Further investigation required. |
Uh oh!
There was an error while loading.Please reload this page.
Description
Added Floor settings tests in model armor as issue b/424365799 is fixed.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only