Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(appengine): quickstart version#10010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
manishchaudhari-ssk wants to merge5 commits intoGoogleCloudPlatform:main
base:main
Choose a base branch
Loading
frommanishchaudhari-ssk:appengine-version-updates

Conversation

manishchaudhari-ssk
Copy link

@manishchaudhari-sskmanishchaudhari-ssk commentedFeb 3, 2025
edited by iennae
Loading

  • Updated the Java version in app.yaml in app-engine-java21 directory
  • Buganizer: b/393352626

@snippet-botSnippet Bot
Copy link

snippet-botbot commentedFeb 3, 2025
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated bysnippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, addsnippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-labelproduct-auto-labelbot added the samplesIssues that are directly related to samples. labelFeb 3, 2025
Copy link

@ghostghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary of the changes for you and other reviewers to get up to speed quickly:

This pull request updates the Java version in the App Engine Qwik Start sample to Java 21. The changes are focused on theappengine-java21/helloworld/http-server directory.

Intent:

The primary goal is to modernize the sample application by using the latest Java version, improving compatibility and potentially leveraging new features.

Changes:

  • Theapp.yaml file was updated to specifyruntime: java21. (Line 16 ofappengine-java21/helloworld/http-server/src/main/appengine/app.yaml)
  • A newREADME.md file was added to provide instructions for deploying the updated application. (File:appengine-java21/helloworld/http-server/README.md)
  • Thepom.xml file was updated to reflect the Java 21 runtime. (File:appengine-java21/helloworld/http-server/pom.xml)
  • The main application file (Main.java) remains largely unchanged, demonstrating a simple HTTP server. (File:appengine-java21/helloworld/http-server/src/main/java/com/example/appengine/Main.java)

Activity:

The pull request references Buganizer issuehttp://b/393352626, suggesting this is part of a larger effort to update App Engine samples.

I'll provide a more detailed review shortly. Thanks!


And now, a little haiku to brighten your day:

Java twenty-one,
Code compiles, a clean deploy,
Happy coding now!

Copy link

@ghostghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This pull request updates the Java version to Java 21 in the App Engine sample application. The changes include updatingapp.yaml, adding apom.xml for Maven build management, and creating aREADME.md file with instructions. The implementation looks good overall, and the added documentation is helpful. Here are a few minor suggestions:

Summary of Google Java Style Guide elements referenced:

  • Comments: Documented using Javadoc style.
  • Naming: Used descriptive names for classes and variables.

@minherzminherz removed their assignmentFeb 3, 2025
@iennaeiennae added kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsFeb 11, 2025
@kokoro-teamkokoro-team removed kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsFeb 11, 2025
@telpiriontelpirion changed the titleVersion updates: App Engine: Qwik Start - Javafeat(appengine): quickstart versionFeb 27, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

issue(blocking): remove this file. All usage documentation should be provided on cloud.google.com.

@telpirion
Copy link
Contributor

Hello@manishchaudhari-ssk -- it doesn't look like my comment has been addressed; I am going to switch this to a draft PR.

@telpiriontelpirion marked this pull request as draftMarch 24, 2025 20:43
@telpiriontelpirion removed their assignmentJul 10, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@telpiriontelpiriontelpirion requested changes

@yoshi-approveryoshi-approverAwaiting requested review from yoshi-approveryoshi-approver is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
samplesIssues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@manishchaudhari-ssk@telpirion@iennae@minherz@kokoro-team

[8]ページ先頭

©2009-2025 Movatter.jp