Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Move bidi to api-core#6211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
crwilcox merged 3 commits intogoogleapis:masterfromcrwilcox:move-bidi
Oct 16, 2018
Merged

Conversation

@crwilcox
Copy link
Contributor

No description provided.

@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement. labelOct 15, 2018
Copy link
Contributor

@tseavertseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks like you meant to movebidi.py intoapi_core/google/api_core/, rahter thancore/google/cloud (at least, that is what the import changes say).

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning thecla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set thecla label toyes (if enabled on your project), and then merge this pull request when appropriate.

@googlebotgooglebot added cla: noThis human has *not* signed the Contributor License Agreement. and removed cla: yesThis human has signed the Contributor License Agreement. labelsOct 15, 2018
@crwilcox
Copy link
ContributorAuthor

@tseaver 100% correct. That was an error on my part.

@tseaver
Copy link
Contributor

@crwilcox,@theacodes please clear the CLA flag and merge.

@crwilcoxcrwilcox added cla: yesThis human has signed the Contributor License Agreement. and removed cla: noThis human has *not* signed the Contributor License Agreement. labelsOct 16, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@crwilcoxcrwilcox merged commit92a6380 intogoogleapis:masterOct 16, 2018
tseaver added a commit that referenced this pull requestOct 17, 2018
Error left from PR#6211, when Kokoro was blithely skipping tests.
parthea pushed a commit that referenced this pull requestNov 24, 2025
parthea pushed a commit that referenced this pull requestNov 24, 2025
Error left from PR#6211, when Kokoro was blithely skipping tests.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@tseavertseavertseaver approved these changes

@theacodestheacodestheacodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crwilcox@googlebot@tseaver@theacodes
[8]ページ先頭
©2009-2025 Movatter.jp