- Notifications
You must be signed in to change notification settings - Fork1.6k
Update subscriber example in README to current patterns.#6194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Update subscriber example in README to current patterns.#6194
Uh oh!
There was an error while loading.Please reload this page.
Conversation
anguillanneuf left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could we also updatefrom google.cloud import pubsub_v1?
It's because everywhere else - in the API Library Doc, such as this page:https://googleapis.github.io/google-cloud-python/latest/pubsub/publisher/api/client.html, as well as in our doc samples - we usepubsub_v1.
Or at lease dofrom google.cloud import pubsub_v1 as pubsub, so people will expect that they won't run into any issues using v1.
tseaver commentedOct 12, 2018
Seeaae840a . |
anguillanneuf left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please make the same import statement update for the publisher code block.
anguillanneuf left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oops, approved too quickly. Would need changes on publisher code block too.
tseaver commentedOct 12, 2018
Seefee1735 |
Closes#6189.