Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add grpcio-gcp dependency for cloud spanner#5904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@WeiranFang
Copy link
Contributor

Add grpcio-gcp as extra dependency in google-api-core
Add grpcio-gcp as hard dependency in google-cloud-spanner

@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement. labelSep 8, 2018
@tseaver
Copy link
Contributor

tseaver commentedSep 8, 2018
edited
Loading

Makinggrpcio-gcp a hard dependency ofgoogle-cloud-spanner seems like it involves some risk: I don't know how well that package is supported across all the platforms, but for instance thelatest version has a Python2-only wheel as its only binary distribution. I can't find its repository, either.

/cc@snehashah16

@theacodes
Copy link
Contributor

I'm going to send a PR to fix the wheel situation, then we can merge this.

The repo is athttps://github.com/GoogleCloudPlatform/grpc-gcp-python

WeiranFang reacted with thumbs up emoji

dependencies= [
'google-cloud-core<0.29dev,>=0.28.0',
'google-api-core[grpc]<2.0.0dev,>=1.1.0',
'google-api-core[grpc, grpcio-gcp]<2.0.0dev,>=1.1.0',

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@theacodes
Copy link
Contributor

Universal wheel PR:GoogleCloudPlatform/grpc-gcp-python#99

@WeiranFang
Copy link
ContributorAuthor

WeiranFang commentedSep 10, 2018
edited
Loading

Updated the min version for api_core and published universal wheel package for grpcio-gcp.

As for the release version for api-core and cloud-spanner, should I bump their versions now in this PR, or leave them for you guys when they are ready to release?

@theacodes
Copy link
Contributor

theacodes commentedSep 10, 2018 via email

No, releasetool will handle that.
On Mon, Sep 10, 2018 at 12:56 PM Weiran Fang ***@***.***> wrote: Should I bump api core and cloud spanner versions in this PR, or leave them for you guys when they are ready to release? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#5904 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc8TPEz-8E-LkEltLeWhBoikjElhRks5uZsQCgaJpZM4WfoOh> .

@WeiranFang
Copy link
ContributorAuthor

No, releasetool will handle that.

Thanks! So the next step would be just to release api-core and cloud-spanner, right?

@theacodes
Copy link
Contributor

theacodes commentedSep 10, 2018 via email

Yes, once we merge this. I'll try to do this tomorrow morning. :)
On Mon, Sep 10, 2018 at 2:22 PM Weiran Fang ***@***.***> wrote: No, releasetool will handle that. Thanks! So the next step would be just to release api-core and cloud-spanner, right? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#5904 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc_X-hnE5HZjhjz8OXm_EB2UA7074ks5uZtgEgaJpZM4WfoOh> .
WeiranFang reacted with thumbs up emoji

@tseaver
Copy link
Contributor

We can't get tests passing for this PR untilapi_core/setup.py has the new version number.

@WeiranFang
Copy link
ContributorAuthor

I think we should separate this into 2 pr, one for api core and another one for spanner. So we can release api core before spanner, correct?

@tseaver
Copy link
Contributor

@WeiranFang This PR already touchesapi_core/setup.py: it just needs to bump the version number there so that the constraint inspanner/setup.py is satisfied.@theacodes will make the releases for the two in the order you suggest, but we can't merge without getting the tests passing first.

@WeiranFang
Copy link
ContributorAuthor

I see, thanks for the clarification!

@theacodestheacodes merged commit24d590b intogoogleapis:masterSep 11, 2018
tseaver added a commit that referenced this pull requestSep 21, 2018
#5904 made 'grpcio-gcp' an unconditional dependency.
tseaver added a commit that referenced this pull requestSep 22, 2018
#5904 made 'grpcio-gcp' an unconditional dependency.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tseavertseaverAwaiting requested review from tseaver

1 more reviewer

@theacodestheacodestheacodes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WeiranFang@tseaver@theacodes@googlebot

[8]ページ先頭

©2009-2025 Movatter.jp