- Notifications
You must be signed in to change notification settings - Fork1.6k
BigQuery: docs for Row.keys, items, values, and get functions.#4413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Refactors items, keys to return iterators.- Copies values to prevent mutating the original row object.
ContributorAuthor
tswast commentedNov 17, 2017
Also pushed to |
Contributor
dhermes commentedNov 17, 2017
@tswast LGTM but ISTM you might just be happier putting @jonparrott WDYT? |
ContributorAuthor
tswast commentedNov 20, 2017
Dropped the change to a generator for |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: bigqueryIssues related to the BigQuery API. cla: yesThis human has signed the Contributor License Agreement.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updates behavior to return generators/iterators, more in line with
dict.Follow-up to#4393.
Updates system tests for new generators. Second try at#4410.