Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update create_note.go#5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
lvoelz wants to merge1 commit intoGoogleCloudPlatform:main
base:main
Choose a base branch
Loading
fromlvoelz:main
Open

Conversation

@lvoelz
Copy link

Update create_note.go to use attestations instead of vulnerabilities, in line with go/aa-deprecate-3p-metadata.

Update create_note.go to use attestations instead of vulnerabilities, in line with go/aa-deprecate-3p-metadata.
@lvoelzlvoelz requested review froma team ascode ownersOctober 8, 2025 18:01
@product-auto-labelproduct-auto-labelbot added the samplesIssues that are directly related to samples. labelOct 8, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello@lvoelz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR refactors thecreate_note.go file to use attestations instead of vulnerabilities, aligning with an internal deprecation guideline. The change involves updating thegrafeaspb.Note type fromNote_Vulnerability toNote_Attestation and adjusting the note's content accordingly.

Highlights

  • Intent: This pull request updatescreate_note.go to switch from using 'vulnerabilities' to 'attestations' when creating notes. This change aligns with the deprecation of third-party metadata as described ingo/aa-deprecate-3p-metadata.
  • Changes: The primary change is incontainer_registry/container_analysis/create_note.go. ThecreateNote function'sgrafeaspb.Note type definition has been modified. Specifically, theType field now usesNote_Attestation instead ofNote_Vulnerability, and the associatedVulnerabilityNote structure has been replaced with anAttestationNote containing aHint with aHumanReadableName.
  • Reviewer Activity: No reviewer activity has been recorded yet for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

  1. Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.

@gemini-code-assist
Copy link
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting/gemini review.

@briandorsey
Copy link
Contributor

Thanks for the updates!

It looks like there are some small consistency updates needed:

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

samplesIssues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lvoelz@briandorsey

[8]ページ先頭

©2009-2025 Movatter.jp