Commit626cb12

wxiaoguang

authored and

GiteaBot

committed

Fix ACME panic (go-gitea#33178)

Fixgo-gitea#33177, Manually tested:````1.7364311850484018e+09infomaintenancestarted background certificate maintenance{"cache": "0x1400ca64180"}1.736431185054049e+09infoobtainacquiring lock{"identifier": "example.com"}1.736431185058073e+09infoobtainlock acquired{"identifier": "example.com"}1.736431185058133e+09infoobtainobtaining certificate{"identifier": "example.com"}````

1 parent3cfff5a commit626cb12Copy full SHA for 626cb12

File tree

1 file changed

-2

lines changed

cmd
- web_acme.go

1 file changed

-2

lines changed

`‎cmd/web_acme.go‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -54,8 +54,10 @@ func runACME(listenAddr string, m http.Handler) error {`
`54`	`54`	`altTLSALPNPort=p`
`55`	`55`	`}`
`56`	`56`
`57`		`-magic:=&certmagic.Default`
`58`		`-magic.Storage=&certmagic.FileStorage{Path:setting.AcmeLiveDirectory}`
	`57`	`+// FIXME: this path is not right, it uses "AppWorkPath" incorrectly, and writes the data into "AppWorkPath/https"`
	`58`	`+// Ideally it should migrate to AppDataPath write to "AppDataPath/https"`
	`59`	`+certmagic.Default.Storage=&certmagic.FileStorage{Path:setting.AcmeLiveDirectory}`
	`60`	`+magic:=certmagic.NewDefault()`
`59`	`61`	`// Try to use private CA root if provided, otherwise defaults to system's trust`
`60`	`62`	`varcertPool*x509.CertPool`
`61`	`63`	`ifsetting.AcmeCARoot!="" {`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit626cb12

File tree

1 file changed

1 file changed

`‎cmd/web_acme.go‎`

0 commit comments