Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Allow hiding toolbar for one session or persistent#3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
viktorrenkema wants to merge3 commits intomain
base:main
Choose a base branch
Loading
fromviktor/toolbar/hide-and-close

Conversation

viktorrenkema
Copy link
Contributor

@viktorrenkemaviktorrenkema commentedOct 3, 2025•
edited
Loading

This PR adds a menu to the toolbar shown on either preview/CR links or to authenticated users to:

  • minify toolbar
  • close toolbar this session
  • dont show toolbar anymore at all (stored in local storage, our docs will havean article explaining how to get it back)

Also the styles are updated a bit & using motion values for a much smoother magnification effect.

Still coming up: dragging (needs some more time as the variable width makes it harder)

CleanShot.2025-10-03.at.12.51.41.mp4

@changeset-botchangeset-bot
Copy link

changeset-botbot commentedOct 3, 2025•
edited
Loading

⚠️ No Changeset found

Latest commit:ef53ff9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@argos-ciArgos CI
Copy link

argos-cibot commentedOct 3, 2025•
edited
Loading

The latest updates on your projects. Learn more aboutArgos notifications ↗︎

BuildStatusDetailsUpdated (UTC)
customers-v2 (Inspect)⚠️ Changes detected (Review)50 changedOct 7, 2025, 7:08 AM
v2-cloudflare (Inspect)⚠️ Changes detected (Review)7 changedOct 7, 2025, 7:11 AM
v2-vercel (Inspect)⚠️ Changes detected (Review)9 changedOct 7, 2025, 7:10 AM

constSTORAGE_KEY='gitbook_toolbar_closed';

try{
consthidden=!!localStorage.getItem(STORAGE_KEY);
Copy link

@sdirosasdirosaOct 7, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Shouldn't we use something likelocalStorage from@gitbook/util-local-storage?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Or how does it work on GBO? We let it crash?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ah thanks for pointing that out, we do actually have utils already in gbo that i didnt notice:https://github.com/GitbookIO/gitbook/blob/viktor/toolbar/hide-and-close/packages/gitbook/src/lib/browser/local-storage.ts#L24. I've pushed a commit where I am using those now, and those handle the scenario where the operation fails:ef53ff9

sdirosa reacted with thumbs up emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sdirosasdirosasdirosa approved these changes

@nolannbironnolannbironnolannbiron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@viktorrenkema@sdirosa@nolannbiron
[8]ページ先頭
©2009-2025 Movatter.jp