NotificationsYou must be signed in to change notification settings
Fork4k
Star28.1k

Fix visual tests on Cloudflare#3133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

SamyPesse wants to merge5 commits intomain

base:main

Choose a base branch

fromcloudflare/fix-math

Draft

Fix visual tests on Cloudflare#3133

SamyPesse wants to merge5 commits intomainfromcloudflare/fix-math

Conversation

Copy link

Member

SamyPesse commentedApr 9, 2025

No description provided.

Fix assets URLs when base finishes with a slash

93f467c

Copy link

changeset-botbot commentedApr 9, 2025•
edited
Loading

⚠️ No Changeset found

Latest commit:730771b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

SamyPesse deployed to2c-preview

April 9, 2025 17:34

— with

GitHub Actions View deployment

SamyPesse deployed to2v-preview

April 9, 2025 17:34

— with

GitHub Actions View deployment

SamyPesse deployed to1c-preview

April 9, 2025 17:34

— with

GitHub Actions View deployment

Copy link

Contributor

github-actionsbot commentedApr 9, 2025•
edited
Loading

Summary of the deployments:

Version 1

Version	URL	Status
Latest commit	https://79f82499.gitbook-open.pages.dev	✅
PR	https://pr3133.gitbook-open.pages.dev	✅

Version 2

Version	URL	Status
Vercel	https://gitbook-v2-ng0jec0a5-gitbook.vercel.app	✅
Cloudflare	https://157ded5c-gitbook-open-v2-preview.gitbook.workers.dev	✅

Test content

Site	`v1`	`2v`	`2c`
GitBook	https://79f82499.gitbook-open.pages.dev/docs.gitbook.com	https://gitbook-v2-ng0jec0a5-gitbook.vercel.app/url/docs.gitbook.com	https://157ded5c-gitbook-open-v2-preview.gitbook.workers.dev/url/docs.gitbook.com
E2E	https://79f82499.gitbook-open.pages.dev/gitbook.gitbook.io/test-gitbook-open	https://gitbook-v2-ng0jec0a5-gitbook.vercel.app/url/gitbook.gitbook.io/test-gitbook-open	https://157ded5c-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.gitbook.io/test-gitbook-open

Copy link

argos-cibot commentedApr 9, 2025•
edited
Loading

The latest updates on your projects. Learn more aboutArgos notifications ↗︎

Build	Status	Details	Updated (UTC)
customers-v1 (Inspect)	✅ No changes detected	-	Apr 9, 2025, 9:31 PM
customers-v2 (Inspect)	✅ No changes detected	-	Apr 9, 2025, 9:34 PM
default (Inspect)	⚠️ Changes detected (Review)	1 changed	Apr 9, 2025, 9:34 PM
v2-vercel (Inspect)	✅ No changes detected	-	Apr 9, 2025, 9:34 PM