- Notifications
You must be signed in to change notification settings - Fork17
Simplifytry_acquire method#245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
JoaquinPolonuer commentedFeb 24, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Moved this here from |
jamesbraza left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice work, LGTM
| withpytest.raises(TimeoutError): | ||
| awaitGLOBAL_LIMITER.try_acquire(("get","test"),acquire_timeout=2) | ||
| # Then we pass an impossible limit, but with a timeour high enough to succeed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| # Then we pass an impossible limit, but with atimeour high enough to succeed | |
| # Then we pass an impossible limit, but with atimeout high enough to succeed |
Re-reading this, I just noticed a typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For fun I madecodespell-project/codespell#3656 for this, lol
No description provided.