Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork244
docs: replace remainingpurgecss
bypurgeCSSPlugin
#1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
julien-deramond wants to merge1 commit intoFullHuman:mainChoose a base branch fromjulien-deramond:main-jd-fix-doc-import-purgeCSSPlugin
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
docs: replace remainingpurgecss
bypurgeCSSPlugin
#1349
julien-deramond wants to merge1 commit intoFullHuman:mainfromjulien-deramond:main-jd-fix-doc-import-purgeCSSPlugin
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Proposed changes
This PR proposes two minor documentation updates to reflect recent changes regarding the use of
purgeCSSPlugin
. Additionally, it addresses any potential oversights wherepurgecss
was still referenced instead ofpurgeCSSPlugin
.The modification to
docs/getting-started.md
appeared straightforward, especially when compared to similar changes we've made in the past. Specifically, we're not utilizing the imported item in this case.For the update to
packages/postcss-purgecss/README.md
, I tested the approach locally. However, since I'm not an advanced user of PurgeCSS, there may be nuances I've missed, so I'm open to feedback on this part.Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Lint and unit tests pass locally with my changes
main
branch(N/A) I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)
Further comments
N/A