Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

LoadKeys() use env + slog.Debug + refactor#24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Foxboron merged 3 commits intoFoxboron:masterfromjtagcat:symlink
Oct 19, 2023
Merged

LoadKeys() use env + slog.Debug + refactor#24

Foxboron merged 3 commits intoFoxboron:masterfromjtagcat:symlink
Oct 19, 2023

Conversation

@jtagcat
Copy link
Contributor

No description provided.

@jtagcatjtagcat temporarily deployed to Build, sign, release binariesOctober 14, 2023 13:19 — withGitHub Actions Inactive
@jtagcatjtagcat temporarily deployed to Build, sign, release binariesOctober 14, 2023 13:19 — withGitHub Actions Inactive
@jtagcatjtagcat temporarily deployed to Build, sign, release binariesOctober 14, 2023 13:19 — withGitHub Actions Inactive
@jtagcat
Copy link
ContributorAuthor

jtagcat commentedOct 14, 2023
edited
Loading

Continuing discussion from#23:

Refactor: keep functions small1, less nested, and exit early. Named itcreateListener (notlistener, since it would result in variable shadowing). I ended up refactoring the bottom part, since there was a shadowederr inmain()2.

My.ssh directory is a symlink. As there is no apparent reason for avoiding symlinks (neither is there precedent from ssh-agent, etc), I made it follow symlinks.

Turns out ssh-tpm-agent didn't use$SSH_AUTH_SOCK, as specified in the systemd unit, now it does.

The debug statements (and a small refactor in main()) are because it didn't give me any error before. Now I am staring at:
level=DEBUG msg="%s not a TPM sealed key: %v\n" /r/c/ssh/hh-8192_ecdsa.tpm="tpm-ssh: unsupported key type \"TPM EC PRIVATE KEY\" edit: fixed by regenerating keys with trunk, not 0.1.0

Footnotes

  1. Pointing tohttps://www.youtube.com/watch?v=CFRhGnuXG-4 again makes me feel like a religious follower of CodeAesthetic, but I'm not. It happens the topics they have videos on matches, and are imo good explanations.

  2. Meaning a 2nd error check was checking an error from far above, not the assumed one.

@jtagcatjtagcat temporarily deployed to Build, sign, release binariesOctober 14, 2023 13:50 — withGitHub Actions Inactive
@jtagcatjtagcat temporarily deployed to Build, sign, release binariesOctober 14, 2023 13:50 — withGitHub Actions Inactive
@jtagcatjtagcat temporarily deployed to Build, sign, release binariesOctober 14, 2023 13:50 — withGitHub Actions Inactive
@jtagcatjtagcat temporarily deployed to Build, sign, release binariesOctober 16, 2023 01:26 — withGitHub Actions Inactive
@jtagcatjtagcat temporarily deployed to Build, sign, release binariesOctober 16, 2023 01:26 — withGitHub Actions Inactive
@jtagcatjtagcat temporarily deployed to Build, sign, release binariesOctober 16, 2023 01:26 — withGitHub Actions Inactive
@jtagcat
Copy link
ContributorAuthor

jtagcat commentedOct 16, 2023
edited
Loading

Resolved conflicts + squashed the linter fix to first commit.

when it is not 5am, i might add context to commits as well 😎 'trying to get it working by understanding it and by understanding, changing it'

@jtagcatjtagcat temporarily deployed to Build, sign, release binariesOctober 16, 2023 01:28 — withGitHub Actions Inactive
@jtagcatjtagcat temporarily deployed to Build, sign, release binariesOctober 16, 2023 01:28 — withGitHub Actions Inactive
@jtagcatjtagcat temporarily deployed to Build, sign, release binariesOctober 16, 2023 01:28 — withGitHub Actions Inactive
@FoxboronFoxboron merged commit25e8edb intoFoxboron:masterOct 19, 2023
@jtagcatjtagcat deleted the symlink branchOctober 23, 2023 06:27
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jtagcat@Foxboron

[8]ページ先頭

©2009-2025 Movatter.jp