- Notifications
You must be signed in to change notification settings - Fork30
agent: add --key-dir as a flag, and warn if key dir is a symlink.#14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Symlinks are generally a bit iffy so I need to think alittle bit about scenarios here. Usually you don't want to arbitrary eval these things. Thoughts@stigtsp? Can run the test suite and probably iterate on it thought, thanks! |
Yeah, I wasn't sure; maybe just warn if |
Imho, an argument to the agent specifying a key dir makes more sense, for cases where you want keys to be stored somewhere else. |
Lets implement Would you be interested doing the work? It shouldn't be very hard. |
14a1f24 toffeafa3Compare
Sure! See latest commit. I rebased and added |
Looks great, thank you!
It could probably just stay inside |
👍 renamed it |
Thanks! |
Uh oh!
There was an error while loading.Please reload this page.
I noticed that
ssh-tpm-agentwon't load keys if$HOME/.sshis a symlink (and won't complain either), becausefilepath.WalkDirdoesn't follow symbolic links. Made me scratch my head for a minute :) I really don't know much about Go, but this seems like a simple fix. Thanks for a sweet tool!Edit - changed to: add
--key-diras a flag, and warn if key dir is a symlink. (See below.)