Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove superfluous methods onGrads#1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
ToucheSir wants to merge2 commits intomaster
base:master
Choose a base branch
Loading
frombc/grads-api-trimming

Conversation

@ToucheSir
Copy link
Member

As far as I can tell, these were never used, tested or documented. Moreover, they don't make sense semantically sinceGrads behaves like a Dict rather than an ordinal-indexed collection like an Array. Meanwhile, their continued existence is causing issues like#1484.

PR Checklist

  • Tests are added
  • Documentation, if applicable

As far as I can tell, these were never used, tested or documented.Moreover, they don't make sense semantically since `Grads` behaves like a Dict rather than an ordinal-indexed collection like an Array.Meanwhile, their continued existence is causing issues like#1484.
@ToucheSir
Copy link
MemberAuthor

After blaming the failed test code, it appears the src file blame is messed up on GH and theactual PR which introduced thisdoes have tests + proper motivation for it. Now I'm not sure what we should do with this functionality. Deprecating it wouldn't get rid of the ambiguities, but it would set us up for removing it along with possibly more of the implicit grads machinery in the future (if we ever get around to that). Adding the suggested methods in#1484 would work, but feels rather unsatisfying and a little hacky. Maybe we could avoid ambiguities by restricting the list of broadcastable functions?

I wishhttps://docs.julialang.org/en/v1/manual/interfaces/#man-interfaces-broadcasting would be a little clearer on how to implement the interface, especially since this is Base's own internal overloads conflicting with us here. WDYT@CarloLucibello@darsnack?

@ToucheSirToucheSir marked this pull request as draftDecember 31, 2023 06:13
@ToucheSirToucheSir added discussion implicitusing Params, Grads labelsDec 31, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

discussionimplicitusing Params, Grads

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ToucheSir

[8]ページ先頭

©2009-2025 Movatter.jp