Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork216
Remove superfluous methods onGrads#1486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
As far as I can tell, these were never used, tested or documented.Moreover, they don't make sense semantically since `Grads` behaves like a Dict rather than an ordinal-indexed collection like an Array.Meanwhile, their continued existence is causing issues like#1484.
ToucheSir commentedDec 31, 2023
After blaming the failed test code, it appears the src file blame is messed up on GH and theactual PR which introduced thisdoes have tests + proper motivation for it. Now I'm not sure what we should do with this functionality. Deprecating it wouldn't get rid of the ambiguities, but it would set us up for removing it along with possibly more of the implicit grads machinery in the future (if we ever get around to that). Adding the suggested methods in#1484 would work, but feels rather unsatisfying and a little hacky. Maybe we could avoid ambiguities by restricting the list of broadcastable functions? I wishhttps://docs.julialang.org/en/v1/manual/interfaces/#man-interfaces-broadcasting would be a little clearer on how to implement the interface, especially since this is Base's own internal overloads conflicting with us here. WDYT@CarloLucibello@darsnack? |
As far as I can tell, these were never used, tested or documented. Moreover, they don't make sense semantically since
Gradsbehaves like a Dict rather than an ordinal-indexed collection like an Array. Meanwhile, their continued existence is causing issues like#1484.PR Checklist
Tests are addedDocumentation, if applicable