Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Move test-containers dependency to test deps#233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
g-krisztian wants to merge3 commits intomain
base:main
Choose a base branch
Loading
fromf-175_move_test-containers_dependency

Conversation

@g-krisztian
Copy link
Collaborator

Title:

Description

Remove direct dependency of test-containers, move it to the examples where it is necessary

Tester info

framework tests and example tests must be fine

Completion Checklist

  • Add description of the changes made here to the changelog file

@soulflyer
Copy link
Contributor

Running the framework tests with ./script/auto.sh -y tests I get 4 failures in config-test. Looks like something to do with ports set in config:

@soulflyer
Copy link
Contributor

Testing xiana.config-testFAIL in (override-with-map) (config_test.clj:44)expected: (= 5000 (get-in config [:xiana/web-server :port]))  actual: (not (= 5000 3333))FAIL in (override-with-map) (config_test.clj:45)expected: (= {:join? false, :port 5000} (get-in config [:xiana/web-server]))  actual: (not (= {:join? false, :port 5000} {:port 3333, :join? false}))FAIL in (override-with-map) (config_test.clj:47)expected: (= {:dbname "framework", :dbtype "postgresql", :host "localhost", :image-name "postgres:14-alpine", :password "postgres", :port 5432, :user "Nobody"} (get-in config [:xiana/postgresql]))  actual: (not (= {:dbname "framework", :dbtype "postgresql", :host "localhost", :image-name "postgres:14-alpine", :password "postgres", :port 5432, :user "Nobody"} {:image-name "postgres:14-alpine", :port 5432, :dbname "framework", :host "localhost", :dbtype "postgresql", :user "postgres", :password "postgres"}))FAIL in (override-with-map) (config_test.clj:55)expected: (= {:host "", :user "", :pass "", :tls true, :port 587, :from "xiana@"} (get-in config [:xiana/emails]))  actual: (not (= {:host "", :user "", :pass "", :tls true, :port 587, :from "xiana@"} {:host "", :user "", :pass "", :tls true, :port 587, :from ""}))

Copy link
Contributor

@soulflyersoulflyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@soulflyersoulflyersoulflyer approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove testing utilities from production code

3 participants

@g-krisztian@soulflyer

[8]ページ先頭

©2009-2025 Movatter.jp