- Notifications
You must be signed in to change notification settings - Fork845
add some config envs: CHROME_EXE_PATH PATCHED_DRIVER_PATH PATCHED_DRIVER_IS_PATCHED#992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
milahu wants to merge3 commits intoFlareSolverr:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
CHROME_EXE_PATHPATCHED_DRIVER_PATHPATCHED_DRIVER_IS_PATCHED
It's not stock -https://github.com/FlareSolverr/FlareSolverr/commits/master/src/undetected_chromedriver |
yeah, i just dont get why undetected_chromedriver is trivial, it can beimplemented in a bash oneliner: |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft PR, because currently, FlareSolverr is using a bundled version of undetected-chromedriver (why?)
in my FlareSolverr package, im using a patched upstream version of undetected-chromedriver
blocked by upstream PRs:
tested. works for me
used in