- Notifications
You must be signed in to change notification settings - Fork845
Modernize and upgrade application#1540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
TheCrazyLex wants to merge7 commits intoFlareSolverr:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Modernize and upgrade application#1540
TheCrazyLex wants to merge7 commits intoFlareSolverr:masterfromTheCrazyLex:modernize-and-update-application
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This commit addresses several points to ensure compatibility with Python 3.13 and incorporates modern Python practices:- Replaced `distutils.version.LooseVersion` with `packaging.version.Version` in `patcher.py` and added `packaging` to dependencies.- Modernized `os.system` calls in `patcher.py` to use `subprocess.run` for better control and error handling.- Updated `setup.py`: - Bumped versions for `selenium`, `requests`, `websockets`, and `packaging`. - Replaced `codecs.open` with standard `open`. - Added Python 3.12 and 3.13 classifiers.- Updated `super()` calls in `__init__.py` to the concise Python 3 syntax.
- The now-updated dependencies and uc all support Python 3.13- Uses newest CI actions and updates pyinstaller version
@ilike2burnthing Please review when you can :) |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request contains multiple upgrades to dependencies and software used, as well as some accompanying fixes and improvements:
In terms of testing, this definitely still needs some, but this is what I have tested:
The CI changes in .github/ were not tested, but are not expected to introduce major issues.