- Notifications
You must be signed in to change notification settings - Fork845
Access iframe in closed shadow root + click on checkbox from iframe body#1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
MCG-pok wants to merge5 commits intoFlareSolverr:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+37 −12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
tifo71 commentedJul 17, 2024
@MCG-pok So it doesn't work now? |
Grivel-l commentedJul 17, 2024
I can confirm this fixed#1253 for me |
Yes it works. I think a better way would be to find how to open the last shadow-root. Maybe I will try to do this later. |
tifo71 commentedJul 17, 2024
@MCG-pok ok great so how to proceed then. Which file do I need to modify? Is there a way to put the fix and make something ready to use? |
People with the right to do it can merge this pull request |
4 tasks
Dupinoux commentedJul 17, 2024
Hi It works for me :) Thank you for the pull request <3 |
BetyOops commentedJul 17, 2024
Thank you@MCG-pok ! It work's perfectly ! |
HpNoTiQ56 commentedJul 17, 2024
Not working in docker env on Unraid with latest tag and flaresolverr_service.py modified mounted. |
can you provide some logs please ? |
HpNoTiQ56 commentedJul 17, 2024
Here are logs (debug info) : |
jcolfej commentedJul 17, 2024
I confirm : works for me ;) |
thank you@HpNoTiQ56 The debug log next to I think you are not running the patched flaresolverr_service.py, maybe it is not well mounted or you got the wrong file ? |
tifo71 commentedJul 17, 2024
can someone put the docker version on a repo please? or tell me how to modify? thanks |
tifo71 commentedJul 17, 2024
@MCG-pok can you integrate the fix to flaresolverr and put it in a repo ? |
HpNoTiQ56 commentedJul 17, 2024
Indeed, wrong file but still error with modified path :
|
Sorry, on previous messages I though you were asking the next step to integrate the fix in Flaresolverr |
HpNoTiQ56 commentedJul 17, 2024
|
tifo71 commentedJul 17, 2024
@MCG-pok great i have tried and it work. Man you are god really thankssssssss |
@HpNoTiQ56 I don't understand what happen |
Triskel295 approved these changesJul 17, 2024
Noaaam commentedJul 17, 2024
Hello@MCG-pok! |
sodanexus commentedJul 17, 2024
What is the name of the repo on Docker Hub? |
Fairy-Jeux commentedJul 17, 2024
@MCG-pok how we can have the docker image and setup it please ? |
tifo71 commentedJul 17, 2024
@Fairy-Jeux@ilike2burnthing will update flaresolverr. A new version is coming. He's doing some testing and will put the new version on the repo. |
For me it's not working with animetorrents' login page, resulting in the same loop. |
Getting round to testing now. It may be the case that#1036 is still an issue, but that this PR just gets us back to normal. |
Was able to reproduce the same issue with no change on code. |
In testing I had some working (including YGG), but not others. Went back to check YGG, and it's no longer working for me. |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
There are currently 3 competing solutions in PRs:
I've limited time at the moment, as does the owner, so haven't been able to test these, nevermind compare them. Hopefully that will change soon. Until then, people can use whichever works best for them with the provided images or running/building from source. |
trivarialthea commentedAug 14, 2024
I also have this issue while using the PR code, on animetorrents. Used a long timeout (nothing is behind a VPN) just to verify that it is not the case of#1272 (comment) If there is anything else I can provide, feel free to @ me. |
BrandonG777 commentedAug 20, 2024
Not having much luck on speed.cd or hd-space either |
skjnldsv commentedSep 28, 2024
Stopped working again unfortunately :( |
See the other PRs. |
vladtreny commentedOct 20, 2024
Hello, Element.prototype.attachShadow = function (params) You can just query the dom the same way and see if it is accessible. if accesable, then it was forged somewhere. Will omit this Need to focus on essential part. |
QthePirate commentedJan 12, 2025
Can confirm after building the docker container with the changes it worked. I'm not running in Docker per se, but in K8s. Only thing I had to do that was driving me mad was adjust the amount of memory the pod was allotted and now its good. Bit slow even when no challenge detected, but good. |
tifo71 commentedJan 12, 2025
I repeat, the version that works perfectly is this one:21hsmw/flaresolverr:nodrivertest |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
tifo71 commentedFeb 24, 2025
Use this version alexfozor/flaresolverr:pr-1300-experimental |
This comment was marked as duplicate.
This comment was marked as duplicate.
tifo71 commentedFeb 24, 2025
Try this one thenghcr.io/thephaseless/byparr:latest |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
65 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi ! Here is something fixing issue#1253
At least it works for me since yesterday 🙂
Here is the problem as I understood it:
The checkbox is in a closed shadow root, inside an iframe, inside a closed shadow root. And you can’t get elements in a closed shadow-root.
Most of the work comes from@alexandervlk,here
He made the
_init_driverfunction: it inject a script before page loading that make the first shadow-root open.This is allowing to run a js script to get the Iframe in the first shadow-root (
get_shadowed_iframefunction) , and then switch the driver to the IframeThen, there is the last closed shadow-root. I was not able to find how to make it open. The
_init_driverdoes not inject in the iFrame, and I can’t find how to do it. So I am not able to get the checkbox for now.But I found a workaround by selecting the iframe body (which is just before this last closed shadow-root in DOM tree) and then manage to click on the checkbox from the body.
I never coded in python before, nor I made a pull request on a public github, so be kind 🙏