Commit2b7040a

committed

fix#53 Loss of scale when reading numeric with zero value

1 parentc829350 commit2b7040aCopy full SHA for 2b7040a

File tree

+10

-2

lines changed

+10

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3392,7 +3392,7 @@ def _extract_db_array_to_list(self, esize: int, dtype: int, subtype: int,`
`3392`	`3392`	`elifdtypein (a.blr_short,a.blr_long,a.blr_int64):`
`3393`	`3393`	`val= (0).from_bytes(buf[bufpos:bufpos+esize],'little',signed=True)`
`3394`	`3394`	`ifsubtypeorscale:`
`3395`		`-val=decimal.Decimal(val)/_ten_to[abs(scale)]`
	`3395`	`+val=decimal.Decimal(val).scaleb(-abs(scale))`
`3396`	`3396`	`elifdtype==a.blr_bool:`
`3397`	`3397`	`val= (0).from_bytes(buf[bufpos:bufpos+esize],'little')==1`
`3398`	`3398`	`elifdtype==a.blr_float:`
`@@ -3799,7 +3799,7 @@ def _unpack_output(self) -> tuple:`
`3799`	`3799`	`value= (0).from_bytes(buffer[offset:offset+length],'little',signed=True)`
`3800`	`3800`	`# It's scalled integer?`
`3801`	`3801`	`ifdesc.subtypeordesc.scale:`
`3802`		`-value=decimal.Decimal(value)/_ten_to[abs(desc.scale)]`
	`3802`	`+value=decimal.Decimal(value).scaleb(-abs(desc.scale))`
`3803`	`3803`	`elifdatatype==SQLDataType.DATE:`
`3804`	`3804`	`value=_util.decode_date(buffer[offset:offset+length])`
`3805`	`3805`	`elifdatatype==SQLDataType.TIME:`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -31,3 +31,11 @@ def test_issue_02(db_connection):`
`31`	`31`	`cur.execute('select C1,C2,C3 from T2 where C1 = 1')`
`32`	`32`	`rows=cur.fetchall()`
`33`	`33`	`assertrows== [(1,None,1)]`
	`34`	`+`
	`35`	`+deftest_issue_53(db_connection):`
	`36`	`+withdb_connection.cursor()ascur:`
	`37`	`+cur.execute("select cast('0.00' as numeric(9,2)) from rdb$database")`
	`38`	`+numeric_val=cur.fetchone()[0]`
	`39`	`+numeric_val_exponent=numeric_val.as_tuple()[2]`
	`40`	`+db_connection.commit()`
	`41`	`+assertnumeric_val_exponent==-2`

Comments

(0)