Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update to efcore and .net 10#1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
niekschoemaker wants to merge12 commits intoFirebirdSQL:master
base:master
Choose a base branch
Loading
fromniekschoemaker:feature/efcore-10

Conversation

@niekschoemaker
Copy link
Contributor

@niekschoemakerniekschoemaker commentedNov 20, 2025•
edited
Loading

A lot of JSON related and collections in columns tests have been disabled, as that is not supported.

Otherwise most tests are left enabled except for some specific ones, most of it due to outer joins and json related data.

DyIgor reacted with thumbs up emoji
Comment on lines +16 to +17
<PackageReferenceInclude="xunit"Version="2.9.3" />
<PackageReferenceInclude="xunit.runner.visualstudio"Version="3.1.5">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Exclude this. We can update it in later PR in all projects.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This was done as the newer version of EntityFrameworkCore tests depend on 3.1.3 (runner) and 2.9.3 (xunit.core) so had to be updated to even be able to restore the packages.
So it either has to be seperated into a seperate pr which then ahs to be merged into this one, or simply like this, or I could update it directly into this pr.

@niekschoemaker
Copy link
ContributorAuthor

Alright, I fixed pretty much everything now, most things which are left open, so not fixed, are done for a reason as seen in the comments.

Especially all the conversion tests as explained, the casts there are really odd and not supported by firebird (bool -> numbers, and vice versa) so I disabled those with that reason. Could also re-implement those tests with a custom implementation to test the behavior we do support, but not sure if that's preferred.

And the updates are left open, as those are necessary to even compile, but could be split of into a seperate PR if necessary.

@niekschoemaker
Copy link
ContributorAuthor

Test for FB3.0 seems to hang, did pass on the fork, so retrigger should fix that but can't do that myself.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cincuranetcincuranetAwaiting requested review from cincuranet

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@niekschoemaker@cincuranet
[8]ページ先頭
©2009-2025 Movatter.jp