Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork74
Correction of the return values of the DatabaseInfo methods for determining the insert, read and delete operations#1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ort Firebird Server 2.0.
…per table since the last connection to the database
…per table since the last connection to the database.fixesFirebirdSQL#1157
| IDictionary<short,ulong>readSeqCount=dbInfo.GetReadSeqCount(); | ||
| IDictionary<short,ulong>readIdxCount=dbInfo.GetReadIdxCount(); | ||
| varfbCommand=newFbCommand("SELECT MAX(INT_FIELD) FROM TEST",Connection); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
await using
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does not look like it's here.
| IDictionary<short,ulong>readSeqCount=dbInfo.GetReadSeqCount(); | ||
| IDictionary<short,ulong>readIdxCount=dbInfo.GetReadIdxCount(); | ||
| varfbCommand=newFbCommand("INSERT INTO TEST (INT_FIELD) VALUES (900)",Connection); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
await using
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does not look like it's here.
| IDictionary<string,short>tableNameList=GetTableNameList(); | ||
| shorttableIdTest=tableNameList["TEST"]; | ||
| varfbCommand=newFbCommand("INSERT INTO TEST (INT_FIELD) VALUES (900)",Connection); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
await using
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does not look like it's here.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| if(counter>0) | ||
| result.Add(keyValuePair.Key,counter); | ||
| } | ||
| else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Add}/{ for consistency sake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does not look like it's here.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
fdcastel commentedOct 25, 2024
@cincuranet it appears that all requested changes have been addressed by@DevM900 (but weren't marked as "resolved"). Could you please review and proceed with the merge? |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
cincuranet commentedNov 4, 2024
Not really. Some are still not addressed and going through it again I found some more. |
| IDictionary<short,ulong>readSeqCount=dbInfo.GetReadSeqCount(); | ||
| IDictionary<short,ulong>readIdxCount=dbInfo.GetReadIdxCount(); | ||
| varfbCommand=newFbCommand("SELECT MAX(INT_FIELD) FROM TEST",Connection); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does not look like it's here.
| IDictionary<short,ulong>readSeqCount=dbInfo.GetReadSeqCount(); | ||
| IDictionary<short,ulong>readIdxCount=dbInfo.GetReadIdxCount(); | ||
| varfbCommand=newFbCommand("INSERT INTO TEST (INT_FIELD) VALUES (900)",Connection); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does not look like it's here.
| IDictionary<string,short>tableNameList=GetTableNameList(); | ||
| shorttableIdTest=tableNameList["TEST"]; | ||
| varfbCommand=newFbCommand("INSERT INTO TEST (INT_FIELD) VALUES (900)",Connection); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does not look like it's here.
| privateIDictionary<string,short>GetTableNameList() | ||
| { | ||
| IDictionary<string,short>result=newDictionary<string,short>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does not look like it's here.
| } | ||
| IDictionary<short,ulong>GetAffectedTables(IDictionary<short,ulong>statisticInfoBefore,IDictionary<short,ulong>statisticInfoAfter) | ||
| asyncTask<IDictionary<short,ulong>>GetAffectedTables(IDictionary<short,ulong>statisticInfoBefore,IDictionary<short,ulong>statisticInfoAfter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why Task?
These changes make it possible to analyze the performance of queries.