Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork74
Update FbDataReader.cs#1122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
BFuerchau wants to merge1 commit intoFirebirdSQL:masterChoose a base branch fromBFuerchau:BFuerchau-patch-2
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Change SchemareadingChange GetValues()Advantage:GetValues() with less checks and calls, performance increase until 20%Rewrite GetSchema/GetSchemaAysnc, single request for all fields, Performance less server calls, max FetchSize columns with 1 call, less transactions with additional server calls for begintransaction and committransaction.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change schema reading
Change GetValues()
Advantage:
Some more discussion points:
When in the select command are less primary fields selected than the primary key has, the IsPrimary should not be set to true. We have tables with compound primary key with more the 1 field. But not all fields may be selected. So the adapter can't create a correct update- or delete-command.
This can now simple be checked, if all primary fields of the resultfields schema are in the _fields-array.
A similar problem is with IsUnique.
We have tables with more than 1 unique index or constraint, so not all unique fields can be used for update/delete command. To set IsUnique must be checked with index columns query.
When all fields in the array belongs to the same unique index, the IsUnique can be set.
If more fields with IsUnique are selected, IsUnique can not clearly set.
This can be checked only with additional requests for all defined unique indexes, when any column has IsUnique checked.