Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add serialization of object members for csv.#97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ptahchiev wants to merge2 commits intoFasterXML:2.9
base:2.9
Choose a base branch
Loading
fromptahchiev:9

Conversation

@ptahchiev
Copy link

  • Keep track of object nesting, similar to jackson-dataformat-properties

jdbranham and justutkarsh reacted with thumbs up emoji
 - Keep track of object nesting, similar to jackson-dataformat-properties
@nstdio
Copy link

Is there any problem with this PR?

@cowtowncoder
Copy link
Member

@nstdio At this point there is one practical problem (aside from merge conflict): being new feature, this needs to be rebased against 2.11. But I do not remember any specific problem against the concept: my main question would be that since@JsonUnwrapped allows similar usage, whether overlap is problematic. Maybe it isn't, but functionality-wise this covers similar case -- however, I can see how with multi-format output, not using that annotation would be preferable.

I will add this PR to my todo list to have another look as it seems valuable, in helping deal with nested values in CSV.

nstdio reacted with thumbs up emoji

@nstdio
Copy link

@cowtowncoder yes, exactly. Also, users not always control/own models and adding a@JsonUnwrappd annotation might be not an option.

@cowtowncoder
Copy link
Member

cowtowncoder commentedNov 26, 2019
edited
Loading

Ok. So, finally getting to this one.... and realizing there are actually couple of problems to resolve.

A practical one is that unfortunately patch has re-styled code, making diff unnecessarily large, and adding work when I have to undo many (not all, just many) changes.
Since I will need to rebase it to be from 2.11, manually, these are bit unfortunate.

But a bigger one is this: I don't want additional processing overhead for common case of no nesting. So will need to figure out how to avoid automatic prepending and only change name in cases where it is needed for nesting.

So this may take a bit longer yet.

cowtowncoder added a commit that referenced this pull requestNov 26, 2019
cowtowncoder added a commit that referenced this pull requestNov 26, 2019
@cowtowncoder
Copy link
Member

Another thing I am not sure about is addition of path separator per column; not sure how that would work compared to per document (one for wholeCsvSchema) would work. Reformatting is especially disruptive forCsvSchema in general.

@branaway
Copy link

I'd love to see this feature goes in the code. since CVS is much more compact than JSON in dealing with large data set. In my case I have to convert between json and CSV without any predefined POJO involved. This is much needed and I don't want to create a fork out of the official Jackson

@cowtowncoder
Copy link
Member

Note: would like to consider this, but would need rework to merge against 2.13 (next applicable minor version).

@cowtowncoder
Copy link
Member

Ok so due to unfortunate reformatting of this patch (probably accidentally done by some reformatter?), it's bit difficult to follow, but now realized that this would only support serialization, not deserialization.
Not quite sure if that makes sense on its own; users might be surprised to find they can serialize things but not deserialize.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ptahchiev@nstdio@cowtowncoder@branaway

[8]ページ先頭

©2009-2025 Movatter.jp