Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix for #356, multiple class adapted for the feature.#357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
perilbrain wants to merge2 commits intoFasterXML:3.x
base:3.x
Choose a base branch
Loading
fromperilbrain:issues/356/remove_hard_coding

Conversation

@perilbrain
Copy link

@perilbrainperilbrain commentedAug 17, 2019
edited by cowtowncoder
Loading

(fix for#356)

  • Accepts new annotation for collection type.

Hey I have made a few improvements to fix the issue. All tests cases are passing but I definitely need a review for this commit.

- Accepts new annotation for collection type.
@perilbrainperilbrain changed the titleFix for #336, multiple class adapted for the feature.Fix for #356, multiple class adapted for the feature.Aug 18, 2019
This functional usually called from the factories of various frameworks like spring needs to resolve the the type of `value` directly rather than trying to figure parameter of some generic.
@cowtowncoder
Copy link
Member

Ah, this looks good I think; I will try to go through with it in more detail, but wanted to mention that this is on my radar for things to go in 2.10 (but I'm also bit overload with all changes :) ).

Only one more question: have I already asked for CLA? If not, it's here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and we'd need a filled copy before first merged contribution (apologies if I have already asked and gotten one).
Easiest way usually is to print it, fill & sign, scan, email toinfo at fasterxml dot com.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@perilbrain@cowtowncoder

[8]ページ先頭

©2009-2025 Movatter.jp