Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: support federation 2.7#2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
samuelAndalon merged 10 commits intoExpediaGroup:masterfromSamjin:fed27
Apr 29, 2025
Merged

Conversation

@Samjin
Copy link
Contributor

@SamjinSamjin commentedApr 14, 2025•
edited
Loading

Support federation v2.7. Here'sdirective details
Supportprogressive @override directive.

These directives will require specific federation versions to generate schema.

  1. @authenticate directive is generated from2.5+
  2. @requiresScopes directive is generated from2.5+
  3. @policy directive is generated from2.6+
  4. @composeDirective directive is generated from2.1+
  5. @interfaceObject directive is generated from2.3+
  6. @override directive with 2nd argument oflabel from2.7

@dariuszkuc
Copy link
Collaborator

Currently this lib allows you specify you own custom@link federation spec import -> this change does not account for this and will update directive definitions even if folks specifically target older versions of federation

@SamjinSamjin marked this pull request as draftApril 14, 2025 18:11
@Samjin
Copy link
ContributorAuthor

Currently this lib allows you specify you own custom@link federation spec import -> this change does not account for this and will update directive definitions even if folks specifically target older versions of federation

Had a brief discussion, the plan is to check if progressive override label would work with older fed version from composition. if not, we'll have to check fed version per directives to make sure they are correctly generated.

@Samjin
Copy link
ContributorAuthor

Samjin commentedApr 19, 2025•
edited
Loading

Somehow fed2.7.5 with Router1.47.0 failed,
but2.7.2 withv1.45.1 worked for composition check.
https://www.apollographql.com/docs/graphos/routing/federation-version-support

@SamjinSamjin marked this pull request as ready for reviewApril 19, 2025 00:05
@SamjinSamjin requested review fromdariuszkuc andsamuelAndalon and removed request fordariuszkucApril 21, 2025 23:34
@Samjin
Copy link
ContributorAuthor

Somehow fed2.7.5 with Router1.47.0 failed, but2.7.2 withv1.45.1 worked for composition check.https://www.apollographql.com/docs/graphos/routing/federation-version-support

Confirmed with Apollo it is a Rover bug and fixed with federation=2.7.8

@SamjinSamjin changed the titleAdd label as optional arg to @override directivefeat: add label as optional arg to @override directiveApr 29, 2025
@samuelAndalonsamuelAndalon merged commit7b9676c intoExpediaGroup:masterApr 29, 2025
11 checks passed
@SamjinSamjin changed the titlefeat: add label as optional arg to @override directivefeat: support federation 2.7Apr 29, 2025
Samjin added a commit to Samjin/graphql-kotlin that referenced this pull requestApr 29, 2025
…2088)Support federation v2.7. Here's [directivedetails](https://www.apollographql.com/docs/graphos/schema-design/federated-schemas/reference/directives)Support [progressive@OverRidedirective](https://www.apollographql.com/docs/graphos/schema-design/federated-schemas/reference/directives#progressive-override).These directives will require specific federation versions to generateschema.1. `@authenticate` directive is generated from `2.5+` 2. `@requiresScopes` directive is generated from `2.5+` 3. `@policy` directive is generated from `2.6+` 4. `@composeDirective` directive is generated from `2.1+` 5. `@interfaceObject ` directive is generated from `2.6+` 6. `@override` directive with 2nd argument of `label` from `2.7`---------Co-authored-by: sjin <sjin@expediagroup.com>
Samjin added a commit that referenced this pull requestApr 29, 2025
cherry pick#2088 to8.x.xCo-authored-by: sjin <sjin@expediagroup.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@samuelAndalonsamuelAndalonsamuelAndalon approved these changes

@dariuszkucdariuszkucAwaiting requested review from dariuszkuc

@tapaderstertapadersterAwaiting requested review from tapaderster

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Samjin@dariuszkuc@samuelAndalon
[8]ページ先頭
©2009-2025 Movatter.jp