Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update flood_inundation_mapping_using_sar_data_and_deep_learning.ipynb#2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
shivanip32 wants to merge1 commit intoEsri:next
base:next
Choose a base branch
Loading
fromshivanip32:flood_inundation_sar_nbk

Conversation

shivanip32
Copy link
Contributor

@shivanip32shivanip32 commentedApr 15, 2025
edited
Loading

updated the notebook

<insert pull request description here>


Checklist

Please go through each entry in the below checklist and mark an 'X' if that condition has been met. Every entry should be marked with an 'X' to be get the Pull Request approved.

  • Allimports are in the first cell?
    • First block of imports are standard libraries
    • Second block are 3rd party libraries
    • Third block are allarcgis imports? Note that in some cases, for samples, it is a good idea to keep the imports next to where they are used, particularly for uncommonly used features that we want to highlight.
  • AllGIS object instantiations are one of the following?
    • gis = GIS()
    • gis = GIS('home') orgis = GIS('pro')
    • gis = GIS(profile="your_online_portal")
    • gis = GIS(profile="your_enterprise_portal")
  • If this notebook requires setup or teardown, did you add the appropriate code to./misc/setup.py and/or./misc/teardown.py?
  • If this notebook references any portal items that need to be staged on AGOL/Python API playground, did you coordinate with a Python API team member to stage the item the correct way with theapi_data_owner user?
  • If the notebook requires working with local data (such as CSV, FGDB, SHP, Raster files), upload the files as items to theGeosaurus Online Org usingapi_data_owner account and change the notebook to first download and unpack the files.
  • Code simplified & split out across multiple cells, useful comments?
  • Consistent voice/tense/narrative style? Thoroughly checked for typos?
  • All images used like<img src="base64str_here"> instead of<img src="https://some.url">? All map widgets contain a static image preview? (Callmapview_inst.take_screenshot() to do so)
  • All file paths are constructed in an OS-agnostic fashion withos.path.join()? (Instead ofr"\foo\bar",os.path.join(os.path.sep, "foo", "bar"), etc.)
  • Is your code formatted usingJupyter Black? You can use Jupyter Black to format your code in the notebook.
  • If this notebook showcases deep learning capabilities, please go through the following checklist:
    • Are the inputs required forExport Training Data Using Deep Learning tool published on geosaurus org (api data owner account) and added in the notebook usinggis.content.get function?
    • Is training data zipped and published as Image Collection? Note: Whole folder is zipped with name same as the notebook name.
    • Are the inputs required for model inferencing published on geosaurus org (api data owner account) and added in the notebook usinggis.content.get function? Note: This includes providing test raster and trained model.
    • Are the inferenced results displayed using a webmap widget?
  • IF YOU WANT THIS SAMPLE TO BE DISPLAYED ON THE DEVELOPERS.ARCGIS.COM WEBSITE, ping@jyaistMap so he can add it to the list for the next deploy.

@review-notebook-appReview Notebook App
Copy link

Check out this pull request on ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered byReviewNB

@review-notebook-appReview Notebook App
Copy link

review-notebook-appbot commentedApr 16, 2025
edited
Loading

View / edit / reply tothis conversation on ReviewNB

neha-sharma-geoai commented on 2025-04-16T05:32:31Z
----------------------------------------------------------------

Should we not hide our usernames in the output path and prevent them from showing to users?


@review-notebook-appReview Notebook App
Copy link

review-notebook-appbot commentedApr 16, 2025
edited
Loading

View / edit / reply tothis conversation on ReviewNB

neha-sharma-geoai commented on 2025-04-16T05:32:32Z
----------------------------------------------------------------

The zoom level is to be given in a new cell after the map has rendered. Are we not syncing the three maps? If we sync, we need to define zoom level only once (in a new cell).


shivanip32 commented on 2025-04-16T05:41:14Z
----------------------------------------------------------------

this is also working fine.

neha-sharma-geoai commented on 2025-04-16T05:56:46Z
----------------------------------------------------------------

That's okay, but repeated lines make it look redundant. We don't need to give the zoom level thrice. It's great if it's working like this, but as I learned from the map team, it should be given in a new cell after the map has rendered. Maybe it's updated now.

Copy link
Contributor

@neha-sharma-geoaineha-sharma-geoai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@shivanip32
Please check the comments.

@shivanip32Review Notebook App
Copy link
ContributorAuthor

this is also working fine.


View entire conversation on ReviewNB

@neha-sharma-geoaiReview Notebook App
Copy link
Contributor

That's okay, but repeated lines make it look redundant. We don't need to give the zoom level thrice. It's great if it's working like this, but as I learned from the map team, it should be given in a new cell after the map has rendered. Maybe it's updated now.


View entire conversation on ReviewNB

@review-notebook-appReview Notebook App
Copy link

review-notebook-appbot commentedApr 18, 2025
edited
Loading

View / edit / reply tothis conversation on ReviewNB

neha-sharma-geoai commented on 2025-04-18T06:20:31Z
----------------------------------------------------------------

L of Learning should be small or else P and C of pixel classification should be capital.


@review-notebook-appReview Notebook App
Copy link

review-notebook-appbot commentedApr 18, 2025
edited
Loading

View / edit / reply tothis conversation on ReviewNB

neha-sharma-geoai commented on 2025-04-18T06:20:32Z
----------------------------------------------------------------

This import is repeated, and it's not importing correctly here.


@review-notebook-appReview Notebook App
Copy link

review-notebook-appbot commentedApr 18, 2025
edited
Loading

View / edit / reply tothis conversation on ReviewNB

neha-sharma-geoai commented on 2025-04-18T06:20:33Z
----------------------------------------------------------------

Please check the grammar.


@review-notebook-appReview Notebook App
Copy link

review-notebook-appbot commentedApr 18, 2025
edited
Loading

View / edit / reply tothis conversation on ReviewNB

neha-sharma-geoai commented on 2025-04-18T06:20:34Z
----------------------------------------------------------------

Should we take this import to first cell?


@review-notebook-appReview Notebook App
Copy link

review-notebook-appbot commentedApr 18, 2025
edited
Loading

View / edit / reply tothis conversation on ReviewNB

neha-sharma-geoai commented on 2025-04-18T06:20:35Z
----------------------------------------------------------------

Please check spellings and grammar.


Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@neha-sharma-geoaineha-sharma-geoaineha-sharma-geoai requested changes

@priyankatutejapriyankatutejaAwaiting requested review from priyankatuteja

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@shivanip32@neha-sharma-geoai

[8]ページ先頭

©2009-2025 Movatter.jp