NotificationsYou must be signed in to change notification settings
Fork313
Star61

Add guidance for restore and initial load#6945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

eatonphil wants to merge10 commits intodevelop

base:develop

Choose a base branch

fromdev/pe/dump-restore

Open

Add guidance for restore and initial load#6945

eatonphil wants to merge10 commits intodevelopfromdev/pe/dump-restore

Conversation

Copy link

Contributor

eatonphil commentedAug 20, 2025

No description provided.

eatonphil requested a review froma team as acode owner

August 20, 2025 00:03

eatonphil requested review fromPJMODOS,mwanner,pavanvd,vadim4o,vaijayanti-b andwind39

August 20, 2025 20:16

PJMODOS reviewed

Aug 21, 2025

View reviewed changes

product_docs/docs/pgd/6/reference/backup-restore.mdx OutdatedShow resolvedHide resolved

eatonphil added6 commits

August 28, 2025 19:52

Dump restore guidance

9857575

up

b47579d

prefer node setup

a6a5fff

More suggestions

974f724

pg_restore

76e8d25

Add backup notes for other versions

4b8237e

eatonphil force-pushed thedev/pe/dump-restore branch from49c8e7a to4b8237eCompare

August 28, 2025 23:55

Add backup notes for other versions

4331478

irionr reviewed

Sep 9, 2025

View reviewed changes

Copy link

Contributor

irionr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would start by configuring/setting the node first and only after that showing the pg_dump/restore commands

product_docs/docs/pgd/6.1/reference/backup-restore.mdx OutdatedShow resolvedHide resolved

product_docs/docs/pgd/6.1/reference/backup-restore.mdxShow resolvedHide resolved

irionr reviewed

Sep 9, 2025

View reviewed changes

product_docs/docs/pgd/6.1/reference/backup-restore.mdx OutdatedShow resolvedHide resolved

irionr reviewed

Sep 9, 2025

View reviewed changes

product_docs/docs/pgd/6.1/reference/backup-restore.mdxShow resolvedHide resolved

Copy link

ContributorAuthor

eatonphil commentedSep 10, 2025

I would start by configuring/setting the node first and only after that showing the pg_dump/restore commands

I don't understand what you mean here sorry

Copy link

Contributor

irionr commentedSep 10, 2025

I would start by configuring/setting the node first and only after that showing the pg_dump/restore commands
I don't understand what you mean here sorry

This is minor. I meant we should first tell them how to configure the nodes, and only after that, to show them the dump and restore commands. Also, I would temporarily adjust these settings even if they use the "pre/data/post" method.
It's only a cosmetic thing probably , but users will just start reading and copying/running the commands before reaching the configuration point.

julienmarcbrown approved these changes

Sep 10, 2025

View reviewed changes

Copy link

ContributorAuthor

eatonphil commentedSep 10, 2025

Wait don't merge this one yet please@julienmarcbrown

consistent

cabb753

Copy link

ContributorAuthor

eatonphil commentedSep 10, 2025

This is minor. I meant we should first tell them how to configure the nodes, and only after that, to show them the dump and restore commands. Also, I would temporarily adjust these settings even if they use the "pre/data/post" method.
It's only a cosmetic thing probably , but users will just start reading and copying/running the commands before reaching the configuration point.

No this is a good point, modified.