Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update all model classes to Electron API 39.2#949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@softworkz
Copy link
Collaborator

@softworkzsoftworkz commentedNov 21, 2025
edited
Loading

...and to electron-updater 6.7.2

@softworkzsoftworkzforce-pushed thesubmit_model_update branch 2 times, most recently from168c984 to5c3128eCompareNovember 21, 2025 23:16
@softworkz
Copy link
CollaboratorAuthor

I had an AI running and working on this for almost 20h - just a few interruptions.

All-in-all it was pretty successful, but only because I had stictly forbidden to make any edits from its own "knowledge" and use a docs MCP server which I had previously fed with the Electron documentation for exactly one version (39.2). This allowed me to check occasionally, whether it had actually queried the information from there. Anyway, my indoctrination has apprently been extreme but successful. It affirmed in every 2nd sentence that all information iis solely taken from the docs server.

I had checked back with the original docs and didn't see any mistake. What could have happened that it missed some new members in the classes (due to the methodology via querying MCP for docs), but I would consider the total result as pretty solid.

Finally, I have reviewed every single changed file and made a number of editis (which also led to the additional commits), also reverted some unnecessary changes in favor of compatibility.

FlorianRappl reacted with rocket emoji

@softworkz
Copy link
CollaboratorAuthor

I had also give special instructions regarding numeric types (doing an assessment whether integral or fractional when the docs to not state anything and build a list of properties where it's unclea).

The ultimate criteria for me were as to whether it would properly identify and change the type of the property which caused the issue that@markatosi had run into (decimal displayFrequecy but int in our definitions):#944

And it did.

@softworkzsoftworkzforce-pushed thesubmit_model_update branch 3 times, most recently from5983f64 toc04c59eCompareNovember 22, 2025 01:16
@softworkz
Copy link
CollaboratorAuthor

Summary

With the extended matrix tests, 10 new test failures have surfaced:https://github.com/ElectronNET/Electron.NET/actions/runs/19586773630/attempts/1#summary-56097317718

Two of them had turrned out to be a timeout issue on newer Electron versions on Windows (takes 1.5s).
It's fixed in this PR (commit "getPrinters: Increase timeout").

The remaining 8 failures were automatically fixed by the model update in this PR (without having been aiming at that).

Now these are the results:

image

But I'm going to remove the matrix-test commit because it belongs intothe other PR.

FlorianRappl reacted with thumbs up emoji

Copy link
Collaborator

@FlorianRapplFlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is awesome!

@FlorianRapplFlorianRappl merged commitc92a54f intoElectronNET:developNov 22, 2025
6 checks passed
@FlorianRapplFlorianRappl added this to the0.3.0 milestoneNov 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@FlorianRapplFlorianRapplFlorianRappl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@softworkz@FlorianRappl

[8]ページ先頭

©2009-2025 Movatter.jp