- Notifications
You must be signed in to change notification settings - Fork70
Support for Serializable-Interface#93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Support for Serializable-Interface#93
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
guidecom-ze commentedApr 15, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
When I readthis comment, I thought that maybe it makes sense to stay on Java 8 for now? Then this PR would be ready for merge and release. And in the other PR we can think about whether we want to stay on Java 8 or use a newer version? |
incandescentxxc commentedApr 18, 2025
@guidecom-ze That works for me. Can you also remove Also, is upgrading Java version a must? Can your project work if we only make the class implement the Serializable interface? |
guidecom-ze commentedApr 22, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hey@incandescentxxc, no there is no need to update the Java version at this moment. I’ve added explicit serialVersionUID fields since it’s generally best practice. However, given our models are short‑lived in this context, it’s not strictly required — happy to remove them if you’d prefer? |
incandescentxxc commentedApr 22, 2025
@guidecom-ze gotcha, that's fine to me. Just approved your PR feel free to merge |
guidecom-ze commentedApr 22, 2025
@incandescentxxc thank you very much! |
Uh oh!
There was an error while loading.Please reload this page.
Since we use Apache Wicket, the model classes used must implement the Serializable Interface. (#91)
Changes in this PR:
@Serialannotation (Java 14+).Because of the annotation
@Serial, the PR#90 has to be merged first.What do you think?