Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support for Serializable-Interface#93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@guidecom-ze
Copy link
Contributor

@guidecom-zeguidecom-ze commentedApr 7, 2025
edited
Loading

Since we use Apache Wicket, the model classes used must implement the Serializable Interface. (#91)

Changes in this PR:

  • config-to-java.py: Add the Serializable interface to all classes.
  • config-to-java.py: Add@Serial annotation (Java 14+).
  • config-to-java.py: Add serialVersionUID to classes.
  • Updates regenerated java classes with Serializable interface.
  • Add Serializable interface to manual created classes

Because of the annotation@Serial, the PR#90 has to be merged first.

What do you think?

@guidecom-zeguidecom-ze marked this pull request as ready for reviewApril 7, 2025 15:14
@guidecom-ze
Copy link
ContributorAuthor

guidecom-ze commentedApr 15, 2025
edited
Loading

When I readthis comment, I thought that maybe it makes sense to stay on Java 8 for now?
I have therefore removed the@Serial annotation again.

Then this PR would be ready for merge and release. And in the other PR we can think about whether we want to stay on Java 8 or use a newer version?

@incandescentxxc
Copy link
Member

@guidecom-ze That works for me. Can you also removeserialVersionUID since it's not used?

Also, is upgrading Java version a must? Can your project work if we only make the class implement the Serializable interface?

@guidecom-ze
Copy link
ContributorAuthor

guidecom-ze commentedApr 22, 2025
edited
Loading

Hey@incandescentxxc, no there is no need to update the Java version at this moment.

I’ve added explicit serialVersionUID fields since it’s generally best practice. However, given our models are short‑lived in this context, it’s not strictly required — happy to remove them if you’d prefer?

@incandescentxxc
Copy link
Member

@guidecom-ze gotcha, that's fine to me. Just approved your PR feel free to merge

@guidecom-ze
Copy link
ContributorAuthor

@incandescentxxc thank you very much!
I don't think I have the required authorizations, do I?

@incandescentxxcincandescentxxc merged commitf89e623 intoECharts-Java:masterApr 22, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@incandescentxxcincandescentxxcincandescentxxc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guidecom-ze@incandescentxxc@mgegc

[8]ページ先頭

©2009-2025 Movatter.jp