- Notifications
You must be signed in to change notification settings - Fork70
Update versions of dependency and java 17#90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| <connection>scm:git:https://github.com/ECharts-Java/ECharts-Java.git</connection> | ||
| <developerConnection>scm:git:https://github.com/ECharts-Java</developerConnection> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
curious what this change is for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Otherwise the maven-site-plugin will fail.
incandescentxxc left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the contribution. Can you also share a screenshot where the project compiles and all tests passed?
guidecom-ze commentedApr 3, 2025
Thanks for your quick feedback! The project compiles and all tests passed: |
incandescentxxc commentedApr 7, 2025
Thank you! |
icepear-jzx commentedApr 14, 2025
Will this introduce backward incompatibility for users still on Java 8? |
incandescentxxc commentedApr 22, 2025
closed for backward compatibility issue. can reopen if there is a real need for upgrading to java 17 |
We would like to use this library to integrate ECharts into our applications.
As a first step, I have updated versions of various dependencies and plugins and migrate the JUnit 4-Tests to JUnit 5.
As the EChart API has evolved, I can imagine adding more PRs to extend the API.
I look forward to your feedback and hope that the library is still alive so that we don't have to implement our own.
We use Apache Wicket and therefore it is mandatory that the classes implement the Serializable interface. However, I would offer this in separate PRs.