- Notifications
You must be signed in to change notification settings - Fork70
add treemap config json files#65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
incandescentxxc commentedAug 2, 2022
related to#59 |
icepear-jzx left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please generate Java files by running the scriptconfig-to-java.py. Remember to format json and java files.
...epear/echarts/origin/chart/treemap/treemap-series-breadcrumb-emphasis-item-style-option.json OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
scripts/config/org/icepear/echarts/origin/chart/treemap/treemap-series-option.json OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
scripts/config/org/icepear/echarts/origin/chart/treemap/treemap-series-option.json OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
scripts/config/org/icepear/echarts/origin/chart/treemap/treemap-series-option.json OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
scripts/config/org/icepear/echarts/origin/chart/treemap/treemap-series-option.json OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...epear/echarts/origin/chart/treemap/treemap-series-breadcrumb-emphasis-item-style-option.jsonShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...ig/org/icepear/echarts/origin/chart/treemap/treemap-series-breadcrumb-item-style-option.jsonShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...ig/org/icepear/echarts/origin/chart/treemap/treemap-series-breadcrumb-item-style-option.json OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
scripts/config/org/icepear/echarts/origin/chart/treemap/treemap-series-breadcrumb-option.json OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
scripts/config/org/icepear/echarts/origin/chart/treemap/treemap-series-level-option.json OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
scripts/config/org/icepear/echarts/origin/chart/treemap/treemap-series-node-item-option.json OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
scripts/config/org/icepear/echarts/charts/treemap/treemap-emphasis.json OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
scripts/config/org/icepear/echarts/origin/chart/treemap/breadcrumb-item-style-option.json OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
scripts/config/org/icepear/echarts/origin/chart/treemap/treemap-emphasis-option.json OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
icepear-jzx commentedAug 7, 2022
Could you create a simplified |
jbaron commentedAug 8, 2022
In case I can help by testing some SNAPSHOT release before sending it to Maven Central, just let me know. |
incandescentxxc commentedAug 9, 2022
added in the latest commit |
Uh oh!
There was an error while loading.Please reload this page.
src/test/java/org/icepear/echarts/advanced/treemap/BasicTreemapChartTest.java OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
icepear-jzx left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
I added the configuration json file to generate actual treemap classes. Before generation, I'd like to have these files to be reviewed first. Major things should be noticed include,
BoxLayoutOptionMixin. I created a new file with a new type calledTreemapSeriesBreadCrumbOption, which extendsBoxLayoutOptionMixinand has those specific fields.BreadcrumbEmphasisItemStyleOptionis a newly named type that does not appear in the original codes.ColorStringis actually a type of String, I used "String" directly.dashArrayX,dashArrayYare some types of Numbers, I used corresponding Number types directly.