Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add treemap config json files#65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
icepear-jzx merged 14 commits intomasterfromtreemap-xxc
Aug 9, 2022
Merged

add treemap config json files#65

icepear-jzx merged 14 commits intomasterfromtreemap-xxc
Aug 9, 2022

Conversation

@incandescentxxc
Copy link
Member

I added the configuration json file to generate actual treemap classes. Before generation, I'd like to have these files to be reviewed first. Major things should be noticed include,

  1. TreemapSeriesOption: breadcrumb is the combination of certain fields withBoxLayoutOptionMixin. I created a new file with a new type calledTreemapSeriesBreadCrumbOption, which extendsBoxLayoutOptionMixin and has those specific fields.
  2. TreemapSeriesBreadCrumbOption:BreadcrumbEmphasisItemStyleOption is a newly named type that does not appear in the original codes.
  3. TreemapSeriesLevelOption:ColorString is actually a type of String, I used "String" directly.
  4. DecalObject:dashArrayX,dashArrayY are some types of Numbers, I used corresponding Number types directly.

@incandescentxxc
Copy link
MemberAuthor

related to#59

Copy link
Member

@icepear-jzxicepear-jzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please generate Java files by running the scriptconfig-to-java.py. Remember to format json and java files.

@icepear-jzx
Copy link
Member

Could you create a simplifiedTreeMap likeSunburst.java?

@jbaron
Copy link

In case I can help by testing some SNAPSHOT release before sending it to Maven Central, just let me know.

@incandescentxxc
Copy link
MemberAuthor

Could you create a simplifiedTreeMap likeSunburst.java?

added in the latest commit

Copy link
Member

@icepear-jzxicepear-jzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@icepear-jzxicepear-jzx merged commitfdcba2e intomasterAug 9, 2022
@icepear-jzxicepear-jzx deleted the treemap-xxc branchAugust 9, 2022 07:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@icepear-jzxicepear-jzxicepear-jzx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@incandescentxxc@icepear-jzx@jbaron

[8]ページ先頭

©2009-2025 Movatter.jp