- Notifications
You must be signed in to change notification settings - Fork597
Add instructions on how to watch for test failures to triage docs#6610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
And remove reference to Jenkins since, while used, is done as part ofa Github Action, and thus there's no separate place to look for failures.
| /** | ||
| **************************************************************************** | ||
| \page page_triager Triager Rotation | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
And remove reference to Jenkins since, while used, is done as part of a Github Action, and thus there's no separate place to look for failures.
nit: Generally the body should stand on its own, including repeating what is in the title if necessary: i.e., best to not start it with "And". The title is not always right there depending on what history tool is used.
api/docs/triager.dox Outdated
| - Do this by going to the Github Actions page: https://github.com/DynamoRIO/dynamorio/actions. | ||
| - If flaky tests are failing too often, assign someone to fix them ASAP, or mark them to be ignored in `runsuite_wrapper.pl`. | ||
| - Watch merges to master for failures on the longer test suite. | ||
| - Do this by watching for merges on the dynamorio-devs@ list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No need to look at the devs list. These are on the same Actions page linked above, to find details -- but the summary page is the green check or red X by each commit athttps://github.com/DynamoRIO/dynamorio/commits/master/ . That's what the goal is: to have that page contain nothing but green checks.
And remove reference to Jenkins since, while used, is done as part of a Github Action, and thus there's no separate place to look for failures.