Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[WiP] Export results#66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
phibos wants to merge16 commits intomaster
base:master
Choose a base branch
Loading
fromexport
Open

[WiP] Export results#66

phibos wants to merge16 commits intomasterfromexport

Conversation

phibos
Copy link
Member

@phibosphibos commentedApr 7, 2017•
edited
Loading

Issue type
  • Feature
Summary

Add experimental support to export the result data in different file formats.

@phibosphibos added this to the0.5 milestoneApr 7, 2017
@phibosphibos self-assigned thisApr 7, 2017
@coveralls
Copy link

coveralls commentedApr 7, 2017•
edited
Loading

Coverage Status

Coverage decreased (-7.2%) to 87.416% when pullingd3e8cc2 on export intodb8f80e on master.

@coveralls
Copy link

coveralls commentedApr 7, 2017•
edited
Loading

Coverage Status

Coverage decreased (-2.5%) to 92.152% when pullingbd77653 on export intodb8f80e on master.

@matkoniecz
Copy link

@DinoTools

What is your opinion/plan about this PR? What is blocking potential merging?

I am asking as this feature would be useful for my purposes.

laurathepluralized reacted with thumbs up emoji

@phibosphibos removed this from the0.5 milestoneApr 14, 2021
@phibos
Copy link
MemberAuthor

Tests are still successful. There are only a few minor style issues. Will finish work on PR#98 and then try to merge this one.

@phibosphibos added this to the0.7 milestoneApr 22, 2021
for way in result.ways:
properties = {}
coordinates = []
for node in way.nodes:
Copy link

@rowanwinsrowanwinsApr 29, 2021•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for this excellent PR!
Just one brief suggestion - Someway's have duplicate first and last coordinates and so they ought to be treated asPolygon rather thanLineString.
For more info check outhttps://wiki.openstreetmap.org/wiki/Way#Types_of_way
and
https://wiki.openstreetmap.org/wiki/Overpass_turbo/Polygon_Features (this info feels a bit more interpretable)

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the information. I will have a look at the documentation.

@phibosphibos removed this from the0.7 milestoneDec 4, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@rowanwinsrowanwinsrowanwins left review comments

Assignees

@phibosphibos

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@phibos@coveralls@matkoniecz@rowanwins
[8]ページ先頭
©2009-2025 Movatter.jp