- Notifications
You must be signed in to change notification settings - Fork4.6k
Repository pattern#71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@Avalon1747 always good to have an autoresponder answering to Github issues ;-) @andrewnester Can you please fix the two things I commented. Other parts look good, so I will merge it then. |
@andrewnester can you please update the PR so I can merge it? |
@domnikl yes, of course, sorry, I was on vacation |
@domnikl btw, seems like doc blocks are ok, where it is not? |
malukenho commentedApr 25, 2014
This is |
minhquy87tb commentedMay 2, 2014
DomniKl you can support Repository pattern using in Laravel 4 Illuminate package ! RepositoryInterface and way to using it ! thank u ! |
@minhquy87tb I have never worked with Laravel 4, so I don't know the details to their repositories. The patterns should be similar, though. This repository should not intend to explain any implementation in any framework in detail. @malukenho Repositories in DDD are defined as: "Mediates between the domain and data mapping layers using a collection-like interface for accessing domain objects.". So yes. |
malukenho commentedMay 5, 2014
@domnikl 👍 |
| public function __construct() | ||
| { | ||
| $this->data = array(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why this has that to be inside of the__constructor() method?
Why not to inicializar alone they?
like ...
private$data =array();private$lastId =0;
It has some specific reason for this?
@andrewnester Looks good now, will merge this in in the next few days. Thank you for adding it! |
Merged. Thanks! |
Implemented repository pattern