[eslint_eslintrc] remove types as of 3.3.0#72026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

typescript-bot merged 1 commit intoDefinitelyTyped:masterfromfasttime:remove-eslint__eslintrc

Mar 1, 2025

Merged

[eslint_eslintrc] remove types as of 3.3.0#72026

typescript-bot merged 1 commit intoDefinitelyTyped:masterfromfasttime:remove-eslint__eslintrc

Mar 1, 2025

Conversation

Copy link

Contributor

fasttime commentedFeb 22, 2025

Please fill in this template.

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from thereadme.
Avoidcommon mistakes.
Runpnpm test <package to test>.

Select one of these and delete the others:

If removing a declaration:

If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
Delete the package's directory.
Add it tonotNeededPackages.json.

@eslint/eslintrc provides its own types as of version 3.3.0. Seeeslint/eslintrc#179.

[eslint_eslintrc] remove types as of 3.3.0

15aa528

fasttime marked this pull request as ready for review

February 22, 2025 08:40

Copy link

Contributor

typescript-bot commentedFeb 22, 2025•
edited
Loading

@fasttime Thank you for submitting this PR!

This is a live comment that I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

1 package in this PR (and infra files)

eslint__eslintrc (probably deleted!) —on npm,on unpkg
- owner-approval:@gdlol
Infra files
- attw.json
- notNeededPackages.json

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PRin the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
✅ A DT maintainer needs to approve changes that affect DT infrastructure (attw.json,notNeededPackages.json)

All of the items on the list are green.To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR

{"type":"info","now":"-","pr_number":72026,"author":"fasttime","headCommitOid":"15aa5284965972c18f3018b183172cbfeacb8bcc","mergeBaseOid":"f103c70c66b26b8df8c83376682fd76d56cb2e70","lastPushDate":"2025-02-22T08:30:33.000Z","lastActivityDate":"2025-03-01T12:24:58.000Z","mergeOfferDate":"2025-02-28T22:24:21.000Z","mergeRequestDate":"2025-03-01T12:24:58.000Z","mergeRequestUser":"fasttime","hasMergeConflict":false,"isFirstContribution":false,"tooManyFiles":false,"hugeChange":false,"popularityLevel":"Popular","pkgInfo": [    {"name":null,"kind":"edit","files": [        {"path":"attw.json","kind":"infrastructure"        },        {"path":"notNeededPackages.json","kind":"infrastructure"        }      ],"owners": [],"addedOwners": [],"deletedOwners": [],"popularityLevel":"Critical","isSafeInfrastructureEdit":false    },    {"name":"eslint__eslintrc","kind":"delete","files": [        {"path":"types/eslint__eslintrc/.npmignore","kind":"package-meta-ok"        },        {"path":"types/eslint__eslintrc/eslint__eslintrc-tests.ts","kind":"test"        },        {"path":"types/eslint__eslintrc/index.d.ts","kind":"definition"        },        {"path":"types/eslint__eslintrc/package.json","kind":"package-meta-ok"        },        {"path":"types/eslint__eslintrc/tsconfig.json","kind":"package-meta-ok"        }      ],"owners": ["gdlol"      ],"addedOwners": [],"deletedOwners": [],"popularityLevel":"Popular"    }  ],"reviews": [    {"type":"approved","reviewer":"RyanCavanaugh","date":"2025-02-28T22:23:43.000Z","isMaintainer":true    },    {"type":"approved","reviewer":"gdlol","date":"2025-02-22T10:04:17.000Z","isMaintainer":false    }  ],"mainBotCommentID":2676095489,"ciResult":"pass"}

typescript-bot added Popular package

This PR affects a popular package (as counted by NPM download counts).

Edits Infrastructure labels

Feb 22, 2025

Copy link

Contributor

typescript-bot commentedFeb 22, 2025

🔔@gdlol — pleasereview this PR in the next few days. Be sure to explicitly selectApprove orRequest Changes in the GitHub UI so I know what's going on.