@dolanmiu Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• tailwindcss (new!)on npm,on unpkg
  • 1 added owner: ✎@dolanmiu

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ❌ Only a DT maintainer can approve changes when there are new packages added

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

{"type":"info","now":"-","pr_number":50921,"author":"dolanmiu","headCommitOid":"3b1d1f5606b2c4285967613d183139d4d083226f","lastPushDate":"2021-03-01T22:40:14.000Z","lastActivityDate":"2021-03-01T22:57:05.000Z","maintainerBlessed":false,"hasMergeConflict":false,"isFirstContribution":false,"popularityLevel":"Well-liked by everyone","pkgInfo": [    {"name":"tailwindcss","kind":"add","files": [        {"path":"types/tailwindcss/colors.d.ts","kind":"definition"        },        {"path":"types/tailwindcss/defaultTheme.d.ts","kind":"definition"        },        {"path":"types/tailwindcss/index.d.ts","kind":"definition"        },        {"path":"types/tailwindcss/resolveConfig.d.ts","kind":"definition"        },        {"path":"types/tailwindcss/tailwind-config.d.ts","kind":"definition"        },        {"path":"types/tailwindcss/tailwindcss-tests.ts","kind":"test"        },        {"path":"types/tailwindcss/tsconfig.json","kind":"package-meta-ok"        },        {"path":"types/tailwindcss/tslint.json","kind":"package-meta-ok"        }      ],"owners": [],"addedOwners": ["dolanmiu"      ],"deletedOwners": [],"popularityLevel":"Well-liked by everyone"    }  ],"reviews": [    {"type":"stale","reviewer":"amcasey","date":"2021-03-01T22:33:15.000Z","abbrOid":"8d91a82"    },    {"type":"stale","reviewer":"themagickoala","date":"2021-02-18T23:08:45.000Z","abbrOid":"8d91a82"    },    {"type":"stale","reviewer":"aivenkimmob","date":"2021-02-18T12:19:24.000Z","abbrOid":"8d91a82"    },    {"type":"stale","reviewer":"peterblazejewicz","date":"2021-02-14T19:50:05.000Z","abbrOid":"8d91a82"    },    {"type":"stale","reviewer":"sheetalkamat","date":"2021-01-29T22:55:24.000Z","abbrOid":"2049749"    }  ],"ciResult":"pass"}

🔔@dolanmiu — you're the only owner, but it would still be good if you find someone toreview this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

tailwindcss (unpkg)

was missing the following properties:

1. postcss

Generated by 🚫dangerJS against8d91a82

👋Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to tailwindcss with its source on master.

@dolanmiu One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

tailwindcss (unpkg)

was missing the following properties:

1. The declaration doesn't match the JavaScript module 'tailwindcss'. Reason:
   The JavaScript module can be called or constructed, but the declaration module cannot.

The most common way to resolve this error is to use 'export =' syntax.
To learn more about 'export =' syntax, seehttps://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require.

1. postcss

Generated by 🚫dangerJS against2049749

This is now done

@sheetalkamat Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@sheetalkamat Could you take a look again please?

@peterblazejewicz,@amcasey,@sheetalkamat Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Where is default theme?

constdefaultTheme=require('tailwindcss/defaultTheme')

it's the object within thetheme property of that default config interfacew

Where is:

constcolors=require('tailwindcss/colors')

this one defaines shapes of the colors used by default config theme

@peterblazejewicz,@sheetalkamat Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@peterblazejewicz My concern is that it will inflate and pollute index.d.ts, and violate separation of concerns

tailwind-config.d.ts is absolutely massive. I am trying to split the code into logical chunks to make future work more maintainable

Look at the following as an example:
https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/jsforce
https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/nodegit

@dolanmiu One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

Can you please address@aivenkimmob's question? The types shouldn't preclude common usage patterns.

done

Could someone merge this in? Everything is addressed

@amcasey I had to revert theexport = resolveConfig; change onresolveConfig.d.ts as it broke the tests

ERROR: 1:8  expect  TypeScript@4.2 compile error: Module '"/Users/dmiu/DefinitelyTyped/types/tailwindcss/resolveConfig"' can only be default-imported using the 'esModuleInterop' flag

@dolanmiu The CI build failed! Pleasereview the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@amcasey,@themagickoala,@aivenkimmob,@peterblazejewicz,@sheetalkamat Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@amcasey I had to revert theexport = resolveConfig; change onresolveConfig.d.ts as it broke the tests

ERROR: 1:8  expect  TypeScript@4.2 compile error: Module '"/Users/dmiu/DefinitelyTyped/types/tailwindcss/resolveConfig"' can only be default-imported using the 'esModuleInterop' flag

The error is correct - you need a default export to use a default import. I'm confused because theunderlying code does not appear to have a default export. However, as you point out, the docs suggest doing it this way, so I'm fine with reverting the export.

I just published@types/tailwindcss@2.0.0 to npm.