- Notifications
You must be signed in to change notification settings - Fork1.8k
feat(ra): Move Risk Acceptance from Engagement to Product level#13780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
kiblik wants to merge1 commit intoDefectDojo:devChoose a base branch
base:dev
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
kiblik commentedNov 26, 2025
- Changed Risk_Acceptance relationship from Engagement (ManyToMany) to Product (ForeignKey)
- Created dedicated risk_acceptance module separate from engagement
- Simplified URLs to use only risk acceptance ID without requiring product/engagement ID
- Added dedicated Product-level Risk Acceptance UI page with navigation tab
- Created 3 separate migration files (0249, 0250, 0251)
- Updated all templates, views, API serializers, and tests
424e179 to43c2b07Comparefe39ea7 to99bcd29Compare- Changed Risk_Acceptance relationship from Engagement (ManyToMany) to Product (ForeignKey)- Created dedicated risk_acceptance module separate from engagement- Simplified URLs to use only risk acceptance ID without requiring product/engagement ID- Added dedicated Product-level Risk Acceptance UI page with navigation tab- Created 3 separate migration files (0249, 0250, 0251)- Updated all templates, views, API serializers, and tests- Adapted to upstream/dev structure with asset/urls.py instead of product/urls.py- Fixed function name from _copy_model_util to copy_model_util for upstream/dev compatibilitySigned-off-by: kiblik <5609770+kiblik@users.noreply.github.com>
99bcd29 toe54840eCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.