- Notifications
You must be signed in to change notification settings - Fork351
chore: refactor config class to a singleton#6803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
chore: refactor config class to a singleton#6803
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This allows to pick up runtime configuration changes in the futureas well as allowing to simplify the code in future PRs. One possiblechange is to remove `configure` and to move the remote configurationto just update the singleton instead.We can add events to activate and deactivate features as soon asupdates are incoming that are not handled by a simple property access.That way most configurations will be changeable at runtime as soonas the remote configuration handles all entries.
Overall package sizeSelf size: 13.17 MB Dependency sizes| name | version | self size | total size ||------|---------|-----------|------------|| @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB || @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB || @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB || @datadog/pprof | 5.11.1 | 9.96 MB | 10.34 MB || @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB || protobufjs | 7.5.4 | 2.95 MB | 5.82 MB || @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB || @opentelemetry/resources | 1.9.1 | 306.54 kB | 1.74 MB || @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB || @opentelemetry/api-logs | 0.207.0 | 201.39 kB | 1.42 MB || @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB || jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB || import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB || lru-cache | 10.4.3 | 804.3 kB | 804.3 kB || @datadog/openfeature-node-server | 0.1.0-preview.12 | 95.11 kB | 401.68 kB || opentracing | 0.14.7 | 194.81 kB | 194.81 kB || source-map | 0.7.6 | 185.63 kB | 185.63 kB || pprof-format | 2.2.1 | 163.06 kB | 163.06 kB || @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB || lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB || ignore | 7.0.5 | 63.38 kB | 63.38 kB || istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB || rfdc | 1.4.1 | 27.15 kB | 27.15 kB || dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB || @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB || tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB || shell-quote | 1.8.3 | 23.74 kB | 23.74 kB || limiter | 1.1.5 | 23.17 kB | 23.17 kB || retry | 0.13.1 | 18.85 kB | 18.85 kB || semifies | 1.0.0 | 15.84 kB | 15.84 kB || jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB || crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB || ttl-set | 1.0.0 | 4.61 kB | 9.69 kB || mutexify | 1.4.0 | 5.71 kB | 8.74 kB || path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB || module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB || escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |🤖 This report was automatically generated byheaviest-objects-in-the-universe |
codecovbot commentedOct 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #6803 +/- ##===========================================- Coverage 84.05% 64.30% -19.76%=========================================== Files 506 298 -208 Lines 21256 11048 -10208 ===========================================- Hits 17867 7104 -10763- Misses 3389 3944 +555 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
datadog-officialbot commentedOct 30, 2025 • edited by datadog-datadog-prod-us1bot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by datadog-datadog-prod-us1bot
Uh oh!
There was an error while loading.Please reload this page.
|
BenchmarksBenchmark execution time: 2025-10-30 22:14:58 Comparing candidate commit9623fa6 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1598 metrics, 72 unstable metrics. |
This allows to pick up runtime configuration changes in the future as well as allowing to simplify the code in future PRs. One possible change is to remove
configureand to move the remote configuration to just update the singleton instead.We can add events to activate and deactivate features as soon as updates are incoming that are not handled by a simple property access.
That way most configurations will be changeable at runtime as soon as the remote configuration handles all entries.