Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat[infrared]: allow disabling automatic signal decoding#273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xMasterX merged 1 commit intoDarkFlippers:devfromdarmiel:feat/playlist
Jan 18, 2023

Conversation

@darmiel
Copy link
Contributor

@darmieldarmiel commentedJan 8, 2023•
edited by xMasterX
Loading

What's new

Adds a new menu itemLean New Remote RAW in the Infrared App, which is only visible when the debug mode is enabled in the settings. When used, automatic decoding of signals is prevented -> you always get a raw capture.

Screen.Recording.2023-01-08.at.02.07.47.mov

Verification

  • Verify that debug mode is disabled (Settings -> System -> Debug -> OFF)
  • Open theInfrared app
  • Learn New Remote RAW should be missing
  • Verify that debug mode is enabled (Settings -> System -> Debug -> ON)
  • Open theInfrared app
  • Learn New Remote RAW should be available
  • UseLearn New Remote and verify that signals are decoded
  • UseLearn New Remote RAW and verify that signals are not decoded

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

amec0e reacted with heart emoji
@amec0e
Copy link
Member

Fiya! 🔥

@forid786
Copy link

Why bother hiding the option when Settings > System > Debug is off? You may as well always make it visible and have some consistency with the Sub Ghz app.

@xMasterX
Copy link
Member

Why bother hiding the option when Settings > System > Debug is off? You may as well always make it visible and have some consistency with the Sub Ghz app.

No, it is not needed for regular usage, normal learn captures raw data if it cannot decode it
This function forces it to disable decoding which is shouldn’t be available to regular users

hiding it in debug is a requirement to have that functionality

darmiel, amec0e, forid786, and Msprg reacted with thumbs up emoji

@forid786
Copy link

Ah okay, yeah that makes sense. Completely forgot that it does automatically fall back to RAW when it cannot decode it.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xMasterXxMasterXAwaiting requested review from xMasterXxMasterX is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@darmiel@amec0e@forid786@xMasterX
[8]ページ先頭
©2009-2025 Movatter.jp